-
Notifications
You must be signed in to change notification settings - Fork 130
Enforce python variable naming conventions for workspace names #39896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
aff6a90 to
14bf9e8
Compare
|
I think if we run the tests in debug mode ~200 will fail. We should aim to fix all of that before this is merged to minimise the number of warning messages users will see when running algorithms that internally use bad workspace names. |
|
This pull request has been automatically marked as stale because it has not had activity in 3 months. It will be closed in 7 days if no further activity occurs. |
|
What is happening with this one? It's still in draft. Should we change the milestone? |
Description of work
A warning message is displayed whenever a workspace is created with a name that doesn't conformt Python variable naming conventions. This will allow us to move to enforcing this standard in the future.
In debug mode, an exception is raised. This will help avoid any new instances of bad workspace names entering the codebase.
To test:
Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
Gatekeeper
As per the gatekeeping guidelines: