Skip to content

Conversation

@thomashampson
Copy link
Contributor

@thomashampson thomashampson commented Nov 4, 2025

Description of work

Closes #40292.

To test:


Reviewer

Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.

As per the review guidelines:

  • Is the code of an acceptable quality? (Code standards/GUI standards)
  • Has a thorough functional test been performed? Do the changes handle unexpected input/situations?
  • Are appropriately scoped unit and/or system tests provided?
  • Do the release notes conform to the guidelines and describe the changes appropriately?
  • Has the relevant (user and developer) documentation been added/updated?
  • If the PR author isn’t in the mantid-developers or mantid-contributors teams, add a review comment rerun ci to authorize/rerun the CI

Gatekeeper

As per the gatekeeping guidelines:

  • Has a thorough first line review been conducted, including functional testing?
  • At a high-level, is the code quality sufficient?
  • Are the base, milestone and labels correct?

@thomashampson thomashampson force-pushed the run-changed-system-tests-on-all-os branch 2 times, most recently from 648bf6a to 4e35a60 Compare November 4, 2025 11:03
@thomashampson thomashampson force-pushed the run-changed-system-tests-on-all-os branch from 4e35a60 to ec66efc Compare November 4, 2025 11:04
@thomashampson
Copy link
Contributor Author

Need to update the jenkins config to save the system test xml files on MacOS and Windows.

@thomashampson
Copy link
Contributor Author

Need to update the jenkins config to save the system test xml files on MacOS and Windows.

I've done this now.

@MialLewis MialLewis moved this to In Progress in ISIS core workstream v6.15.0 Nov 10, 2025
@MialLewis MialLewis added the DevOps Issues and pull requests related to DevOps label Nov 10, 2025
@github-actions github-actions bot added the Has Conflicts Used by the bot to label pull requests that have conflicts label Dec 17, 2025
@github-actions
Copy link
Contributor

👋 Hi, @thomashampson,

Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DevOps Issues and pull requests related to DevOps Has Conflicts Used by the bot to label pull requests that have conflicts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If a system test is changed, run it on all operating systems.

2 participants