-
Notifications
You must be signed in to change notification settings - Fork 129
Update pyvista version requirement to >=0.46 #40370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jclarkeSTFC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standalone builds look fine on Windows and IDAaaS
peterfpeterson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm currently running pyvista 0.46.4 and vtk-base 9.3.1 through pixi. This can be seen in the active pixi.lock.
Do you get the same if you use a |
|
Does this need re-reviewing now that we have moved our CI to pixi? |
|
I'd suggest a rebase then we see what happens |
I think this helps pixi avoid installing an incompatible vtk version.
529be3f to
193e1f7
Compare
I think this helps pixi avoid installing an incompatible vtk version. Co-authored-by: Pete Peterson <petersonpf@ornl.gov>
I think this helps pixi avoid installing an incompatible vtk version.
To test:
Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
mantid-developersormantid-contributorsteams, add a review commentrerun cito authorize/rerun the CIGatekeeper
As per the gatekeeping guidelines: