Skip to content

Conversation

@thomashampson
Copy link
Contributor

@thomashampson thomashampson commented Nov 20, 2025

I think this helps pixi avoid installing an incompatible vtk version.

To test:


Reviewer

Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.

As per the review guidelines:

  • Is the code of an acceptable quality? (Code standards/GUI standards)
  • Has a thorough functional test been performed? Do the changes handle unexpected input/situations?
  • Are appropriately scoped unit and/or system tests provided?
  • Do the release notes conform to the guidelines and describe the changes appropriately?
  • Has the relevant (user and developer) documentation been added/updated?
  • If the PR author isn’t in the mantid-developers or mantid-contributors teams, add a review comment rerun ci to authorize/rerun the CI

Gatekeeper

As per the gatekeeping guidelines:

  • Has a thorough first line review been conducted, including functional testing?
  • At a high-level, is the code quality sufficient?
  • Are the base, milestone and labels correct?

@github-actions github-actions bot added this to the Release 6.15 milestone Nov 20, 2025
@thomashampson thomashampson marked this pull request as ready for review November 21, 2025 15:56
@jclarkeSTFC jclarkeSTFC self-assigned this Nov 24, 2025
@jclarkeSTFC
Copy link
Contributor

Package build Build Status

Copy link
Contributor

@jclarkeSTFC jclarkeSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standalone builds look fine on Windows and IDAaaS

Copy link
Member

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently running pyvista 0.46.4 and vtk-base 9.3.1 through pixi. This can be seen in the active pixi.lock.

@jclarkeSTFC
Copy link
Contributor

I'm currently running pyvista 0.46.4 and vtk-base 9.3.1 through pixi. This can be seen in the active pixi.lock.

Do you get the same if you use a conda environment?

@sf1919
Copy link
Contributor

sf1919 commented Jan 15, 2026

Does this need re-reviewing now that we have moved our CI to pixi?

@jclarkeSTFC
Copy link
Contributor

I'd suggest a rebase then we see what happens

thomashampson and others added 2 commits January 15, 2026 11:36
I think this helps pixi avoid installing an incompatible vtk version.
@jclarkeSTFC jclarkeSTFC merged commit 190f8c2 into main Jan 16, 2026
10 checks passed
@jclarkeSTFC jclarkeSTFC deleted the update-pyvista-pin branch January 16, 2026 15:30
peterfpeterson added a commit to peterfpeterson/mantid that referenced this pull request Jan 16, 2026
I think this helps pixi avoid installing an incompatible vtk version.

Co-authored-by: Pete Peterson <petersonpf@ornl.gov>
peterfpeterson added a commit that referenced this pull request Jan 16, 2026
This pulls the following into `ornl-next`
* #40634 
* #40370

---------

Co-authored-by: mantid-builder <mantid-builder@users.noreply.github.com>
Co-authored-by: thomashampson <thomas.hampson@stfc.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants