Add reset buttons to sliders in new Instrument View

[jclarkeSTFC]

Instead of dragging the contour and integration limit sliders in the new Instrument View, one can now click a reset button to return to the maximum range.

Closes #40776.

• Contour limits are recalculated when the integration limits are changed (since changing the integration limits will update the min and max counts).
• The line plot x-axis will now update when the integration limits are changed.

To test:

Play around with both sliders and min/max edit boxes, check that the button works and the image updates correctly

---

Reviewer

Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.

As per the review guidelines:

• Is the code of an acceptable quality? (Code standards/GUI standards)
• Has a thorough functional test been performed? Do the changes handle unexpected input/situations?
• Are appropriately scoped unit and/or system tests provided?
• Do the release notes conform to the guidelines and describe the changes appropriately?
• Has the relevant (user and developer) documentation been added/updated?
• If the PR author isn’t in the mantid-developers or mantid-contributors teams, add a review comment rerun ci to authorize/rerun the CI

Gatekeeper

As per the gatekeeping guidelines:

• Has a thorough first line review been conducted, including functional testing?
• At a high-level, is the code quality sufficient?
• Are the base, milestone and labels correct?

[jclarkeSTFC]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request implements reset button functionality for the Instrument View sliders. The release notes documentation was updated to reflect the new feature. The view model now stores full limit values for integration and counts ranges. The presenter introduces two new methods to handle integration and contour range reset actions. The window class extends the min/max group box UI component to include reset buttons, adds helper methods to update edit boxes with new limit values, and establishes signal connections between the reset buttons and presenter methods.

Suggested reviewers

• RichardWaiteSTFC
• cailafinn

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The pull request title clearly and concisely describes the main change: adding reset buttons to sliders in the new Instrument View, which is directly supported by the code changes.
Linked Issues check	✅ Passed	The code changes implement the requirement from issue #40776 to add reset buttons for the contour and integration range sliders in the new Instrument View.
Out of Scope Changes check	✅ Passed	All code changes are directly related to implementing reset button functionality for the sliders as specified in issue #40776; no out-of-scope changes are present.
Description check	✅ Passed	The pull request description clearly describes adding reset buttons to the contour and integration limit sliders in the new Instrument View, aligning with the changeset modifications across multiple files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@qt/python/instrumentview/instrumentview/FullInstrumentViewPresenter.py`:
- Around line 144-148: The reset handler on_integration_limits_reset_clicked
calls update_integration_range(...) which recalculates counts but does not
assign the model's integration_limits, leaving _integration_limits stale; after
calling update_integration_range(self._model.full_integration_limits,
entire_range=True) explicitly set the model's integration_limits to the
full_integration_limits (e.g. self._model.integration_limits =
self._model.full_integration_limits or via the model's setter if one exists)
before updating the view with set_integration_range_limits,
set_integration_min_max_boxes and set_view_integration_limits so downstream
save/export reads the updated limits.

[coderabbitai]

Note

Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it.

---

Generating unit tests... This may take up to 20 minutes.

[andy-bridger]

I have played around with it and am happy that it functions as described, I have a few questions as to things that may well be intentional choices and/or targets of future work, so just say the word and I am happy to approve this for what it is.

My main question is for the contour range limits. By having the fixed max and min limits based on the integration of the entire spectrum, if I have cropped to a small subset of my data with the integration limit slider, I can't obtain meaningful contours as all the integrated counts in this new integration range are below the global lower limit - could the contour range limits be dynamic and depend on the integration limits?

Follow up is about the integration limits, and this one is I'm guessing something that has already been discussed/ decided upon. I would have found it useful for testing this if the integration limits chosen were reflected in the plotted spectra as well as in the instrument render, is this going to be done in future?

[jclarkeSTFC]

I have played around with it and am happy that it functions as described, I have a few questions as to things that may well be intentional choices and/or targets of future work, so just say the word and I am happy to approve this for what it is.

My main question is for the contour range limits. By having the fixed max and min limits based on the integration of the entire spectrum, if I have cropped to a small subset of my data with the integration limit slider, I can't obtain meaningful contours as all the integrated counts in this new integration range are below the global lower limit - could the contour range limits be dynamic and depend on the integration limits?

Follow up is about the integration limits, and this one is I'm guessing something that has already been discussed/ decided upon. I would have found it useful for testing this if the integration limits chosen were reflected in the plotted spectra as well as in the instrument render, is this going to be done in future?

Thanks, I think I've implemented both of the things you mentioned, should be more usable now.

[andy-bridger]

Thanks, I think those changes make it much easier to use!

From being easier to use, I've used it a bit more, I think there is probably something which needs to be done for the integration limits when units are in d-spacing. Seemingly from quite a few instruments I've tested you can have a banks of detectors with vastly different d-space ranges, which make the sliders basically pointless (see below for enginx, with a transmission bank that makes the slider pretty unuseable for the diffraction banks)

and to a lesser extent osiris:

I had two ideas for solving the issue (I suppose three if you count "do nothing, address in another PR"):

• Have some to buttons "set new integration limits", "reset slider to integration limit", "reset integration limits"
• Have the integration limits and contour respect masking so at least you can mask out banks that are annoying

I think the former gives more user control but will probably be difficult to make aesthetically pleasing, the latter perhaps should be included either way?