Initial Setup for Engineering Diffraction support of IMAT upgrade#40842
Open
andy-bridger wants to merge 6 commits intomainfrom
Open
Initial Setup for Engineering Diffraction support of IMAT upgrade#40842andy-bridger wants to merge 6 commits intomainfrom
andy-bridger wants to merge 6 commits intomainfrom
Conversation
Contributor
|
👋 Hi, @andy-bridger, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Already a lot of ground work was done for extending to IMAT, mainly just added an instrument config that hands off some of the instrument specific variables when required.
I would imagine a lot of this will be subject to change once we have some actual data available for testing - I'm not really sure how this is so many files and lines changed without any real functionality
Summary of changes:
full instrument calibration pathandprm template filesto an instrument config fileGROUPEnum options to each config rather than having a general one forEnggUtils(these were loading ENGINX specific xml files and in some cases {Texture20/30} no direct analogue will exists for IMAT)instr_configs and handle auto-populated fieldsGROUP{which was exclusively for ENGINX} is used in many places - for the most part I have just replaced the usage with the newENGINX_GROUPas it is rarely the nature of the group itself that is being tested)To test:
Functionally there isn't much that can really be tested at this stage. You can open the EngDiff interface and swap between the instruments and check that instrument dependent settings are being appropriately displayed (full instrument calibration files, previous prm files etc).
But until IMAT provides some actual collimated data I don't think anything can be quantitatively checked.
I don't believe this requires a release note as nothing user facing is changing
Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
mantid-developersormantid-contributorsteams, add a review commentrerun cito authorize/rerun the CIGatekeeper
As per the gatekeeping guidelines: