Draw detectors as their shapes in new Instrument View#40850
Draft
jclarkeSTFC wants to merge 11 commits intomantidproject:mainfrom
Draft
Draw detectors as their shapes in new Instrument View#40850jclarkeSTFC wants to merge 11 commits intomantidproject:mainfrom
jclarkeSTFC wants to merge 11 commits intomantidproject:mainfrom
Conversation
This is slower than drawing them as points, but is a more accurate representation of the instrument. Both points and shapes drawing classes derive from a common base class, to ease switching in the presenter.
When drawing as shapes, and a detector is picked, it will be highlighted by drawing a wireframe outline around it. This is implemented by maintaining a separate mesh containing just the highlighted detector, which is drawn on top of the main mesh. When the highlighted detector changes, we update the vertices of this mesh to match the newly highlighted detector.
jclarkeSTFC
added
the
Epic
github-actions
bot
added
the
Has Conflicts
Contributor
|
👋 Hi, @jclarkeSTFC, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
jclarkeSTFC
removed
the
Has Conflicts
When picking points the detectors are hightlighted in orange, so let's keep consistent behaviour. I also removed some unused arguments in some renderer methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40311.
To test:
Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
mantid-developersormantid-contributorsteams, add a review commentrerun cito authorize/rerun the CIGatekeeper
As per the gatekeeping guidelines: