Updated functionality of GenerateFlatCellWorkspaceLOQ based on instrument scientist feedback#40856
Draft
RabiyaF wants to merge 2 commits intomantidproject:mainfrom
Draft
Updated functionality of GenerateFlatCellWorkspaceLOQ based on instrument scientist feedback#40856RabiyaF wants to merge 2 commits intomantidproject:mainfrom
RabiyaF wants to merge 2 commits intomantidproject:mainfrom
Conversation
f074773 to
3f5da1e
Compare
Contributor
|
👋 Hi, @RabiyaF, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Closes #xxxx.
This PR extends the functionality of
GenerateFlatCellWorkspaceLOQbased on feedback gathered during beta testing. The algorithm now includes the post processing step for streamlining the workflow for the SANS scientists.This PR is blocked and awaiting further clarification on additional changes.
To test:
Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
mantid-developersormantid-contributorsteams, add a review commentrerun cito authorize/rerun the CIGatekeeper
As per the gatekeeping guidelines: