Skip to content

Comments

Updated functionality of GenerateFlatCellWorkspaceLOQ based on instrument scientist feedback#40856

Draft
RabiyaF wants to merge 2 commits intomantidproject:mainfrom
RabiyaF:additional-updates-to-flatcell
Draft

Updated functionality of GenerateFlatCellWorkspaceLOQ based on instrument scientist feedback#40856
RabiyaF wants to merge 2 commits intomantidproject:mainfrom
RabiyaF:additional-updates-to-flatcell

Conversation

@RabiyaF
Copy link
Member

@RabiyaF RabiyaF commented Feb 9, 2026

Description of work

Closes #xxxx.

This PR extends the functionality of GenerateFlatCellWorkspaceLOQ based on feedback gathered during beta testing. The algorithm now includes the post processing step for streamlining the workflow for the SANS scientists.

This PR is blocked and awaiting further clarification on additional changes.

To test:


Reviewer

Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.

As per the review guidelines:

  • Is the code of an acceptable quality? (Code standards/GUI standards)
  • Has a thorough functional test been performed? Do the changes handle unexpected input/situations?
  • Are appropriately scoped unit and/or system tests provided?
  • Do the release notes conform to the guidelines and describe the changes appropriately?
  • Has the relevant (user and developer) documentation been added/updated?
  • If the PR author isn’t in the mantid-developers or mantid-contributors teams, add a review comment rerun ci to authorize/rerun the CI

Gatekeeper

As per the gatekeeping guidelines:

  • Has a thorough first line review been conducted, including functional testing?
  • At a high-level, is the code quality sufficient?
  • Are the base, milestone and labels correct?

@RabiyaF RabiyaF added this to the Release 6.15 milestone Feb 9, 2026
@RabiyaF RabiyaF force-pushed the additional-updates-to-flatcell branch from f074773 to 3f5da1e Compare February 17, 2026 10:32
@github-actions github-actions bot added the Has Conflicts Used by the bot to label pull requests that have conflicts label Feb 17, 2026
@github-actions
Copy link
Contributor

👋 Hi, @RabiyaF,

Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

@RabiyaF RabiyaF changed the base branch from release-next to main February 17, 2026 10:32
@RabiyaF RabiyaF removed the Has Conflicts Used by the bot to label pull requests that have conflicts label Feb 17, 2026
@RabiyaF RabiyaF modified the milestones: Release 6.15, Release 6.16 Feb 17, 2026
@RabiyaF RabiyaF added the ISIS: Blocked Issues and Pull requests that are blocked by factors external to the ISIS Development Team label Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ISIS: Blocked Issues and Pull requests that are blocked by factors external to the ISIS Development Team

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant