Move sans gui out of framework to mantidqtinterfaces#40878
Open
jhaigh0 wants to merge 4 commits intomantidproject:mainfrom
Open
Move sans gui out of framework to mantidqtinterfaces#40878jhaigh0 wants to merge 4 commits intomantidproject:mainfrom
jhaigh0 wants to merge 4 commits intomantidproject:mainfrom
Conversation
Contributor
|
👋 Hi, @jhaigh0, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
c52af98 to
7385ce7
Compare
MialLewis
approved these changes
Feb 18, 2026
Contributor
MialLewis
left a comment
There was a problem hiding this comment.
Have tested the SANS interface via the manual testing instructions, all appears in working order.
The movement of RowEntries and the system test make sense to me.
cailafinn
requested changes
Feb 20, 2026
Contributor
cailafinn
left a comment
There was a problem hiding this comment.
Just one comment on the refactored row_entries.py file.
|
|
||
|
|
||
| @dataclass(eq=False) | ||
| class _UserEntries(object): |
Contributor
There was a problem hiding this comment.
If this file is now a duplicate of the new one in the framework, could this file be deleted and any imports be moved to the one in the framework?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Move the gui_logic out of
scripts/sansto a newmantidqtinterfacesdir.This probably all needs a bit of a refactor but I'm trying to do the minimal changes possible in this pr.
A few things I want opinions on:
RowEntriesmodel (previously ingui_logic/models) has been refactored out to a file now insans/data_objects. This is because it was being used by the command interface (in particular the csv parser) so I needed to eliminated the link betweenscriptsand code which was now inmantidqtinterfaces. Not sure ifdata_objectsis the best dir to put it in?frameworktoqtbecause it now imports frommantidqtinterfaces, but it does split it up from all the other sans systerm tests.It might be good to checkout this branch (or user
git test-prto view the file tree in an IDE to get a good sense of where things have moved to. It's hard to follow on github I think.The goal of this is to eventually remove the qt dependency from the
mantidpackage. There are still a few more places to sort out for this to happen, but this is the majority of it I think.Closes #37952
To test:
Build testing all tests on all branches https://builds.mantidproject.org/job/build_branch/1474/
Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
mantid-developersormantid-contributorsteams, add a review commentrerun cito authorize/rerun the CIGatekeeper
As per the gatekeeping guidelines: