Explicitly delete copy constructors for classes with Poco::NObserver#40958
Draft
rboston628 wants to merge 5 commits intomainfrom
Draft
Explicitly delete copy constructors for classes with Poco::NObserver#40958rboston628 wants to merge 5 commits intomainfrom
Poco::NObserver#40958rboston628 wants to merge 5 commits intomainfrom
Conversation
Contributor
|
👋 Hi, @rboston628, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Poco v1.15 (published to anaconda.org on 2026-02-17) introduces std::atomic into NObserver, which secretly prevents copying of any class with an NObserver object in it. You can only find this out when you go to build on Windows with MSVC and learn it is trying to create a default copy constructor, leading to an error.
This was discovered while making release candidates for mantid v6.15. As pin as added in 6.15 to enable the package build in PR #40957.
The problem is caused in classes with a
NObservermember variable, but without an explicit copy constructor. The MSVC compiler will attempt to create defaults, which is an error. This work deletes the copy constructors in these classes, so that the defaults will not be constructed.To test:
Run a build with a pin in Poco 1.15.
Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
mantid-developersormantid-contributorsteams, add a review commentrerun cito authorize/rerun the CIGatekeeper
As per the gatekeeping guidelines: