Add monitor count handling in LoadNexusProcessed and related tests#41072
Merged
Add monitor count handling in LoadNexusProcessed and related tests#41072
Conversation
jmborr
added
Diffraction
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
…ionHelper and improve file handling Signed-off-by: Jose Borreguero <borreguero@gmail.com>
jmborr
force-pushed
the
save_monitor_count
branch
from
b368076 to
e520ee5
Compare
Contributor
Unit test results2 861 tests 2 861 ✅ 1h 58m 41s ⏱️ Results for commit 16c34cb. ♻️ This comment has been updated with latest results. |
Contributor
System test results808 tests 792 ✅ 2h 4m 57s ⏱️ Results for commit 16c34cb. ♻️ This comment has been updated with latest results. |
Contributor
|
Seems to work with save/load nexus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Saving and loading monitor counts for the two types of peak workspaces.
Changes:
Monitor Countas a new NeXus table column forPeaksWorkspace(column_21) andLeanElasticPeaksWorkspace(column_18).LoadNexusProcessedand apply them back onto each peak viasetMonitorCount.Companion to #41073
Implements EWM 15113
To test:
After building this branch, run script EWM_15113_manual_test.py in Workbench and verify all checks pass.
Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
mantid-developersormantid-contributorsteams, add a review commentrerun cito authorize/rerun the CIGatekeeper
As per the gatekeeping guidelines: