Put Linux workflow back in again#41079
Merged
peterfpeterson merged 9 commits intomainfrom Mar 17, 2026
Merged
Conversation
Contributor
Unit test results2 862 tests 2 862 ✅ 8h 16m 39s ⏱️ Results for commit f53465e. ♻️ This comment has been updated with latest results. |
Contributor
System test results808 tests 792 ✅ 3h 2m 28s ⏱️ Results for commit f53465e. ♻️ This comment has been updated with latest results. |
idigs
approved these changes
Mar 17, 2026
| mkdir -p test_logs | ||
| if [[ $ENABLE_UNIT_TESTS == true ]]; then | ||
| run_with_xvfb ctest -L UnitTest -j$UNIT_TEST_THREADS --no-compress-output -T Test -O test_logs/ctest_$OSTYPE.log --schedule-random --output-on-failure --repeat until-pass:3 $WINDOWS_TEST_OPTIONS $WINDOWS_UNITTEST_TIMEOUT_OPTIONS | ||
| run_with_xvfb ctest -L UnitTest -j$UNIT_TEST_THREADS --no-compress-output -T Test -O test_logs/ctest_$OSTYPE.log --schedule-random --output-on-failure --repeat until-pass:3 $WINDOWS_TEST_OPTIONS $WINDOWS_UNITTEST_TIMEOUT_OPTIONS --output-junit Testing/junit-unittest.xml -E MPIAlgorithmsTest |
Collaborator
There was a problem hiding this comment.
We still need to exclude MPI from tests?
| - uses: actions/checkout@v4 | ||
| with: | ||
| # Needed to fetch the tags for versioningit | ||
| fetch-depth: "0" |
Collaborator
There was a problem hiding this comment.
@peterfpeterson's original suggestion: "Should get plenty of information and speed up cloning"
Suggested change
| fetch-depth: "0" | |
| fetch-depth: "100" | |
| fetch-tags: true |
Contributor
Author
|
Windows test failures are unrelated |
peterfpeterson
pushed a commit
that referenced
this pull request
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Removed the
isislabel so that it can run on any self-hosted linux machine.See here for the original PR.
To test:
GitHub workflow for running unit and system test on Linux should pass.
Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
mantid-developersormantid-contributorsteams, add a review commentrerun cito authorize/rerun the CIGatekeeper
As per the gatekeeping guidelines: