Fixed the help documentation launch link when the plot is a superplot #41083
Merged
SilkeSchomann merged 3 commits intomantidproject:mainfrom Mar 20, 2026
Merged
Conversation
95ebe43 to
0181262
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Workbench plot Help button routing so that when the Superplot mode is active the Help action opens the Superplot documentation (per #38044), otherwise it continues to open the standard plotting help.
Changes:
- Add
FigureType.Superplotand map it to theworkbench/superplot.htmldocumentation page. - Route the Help button action to a Superplot-specific handler when the Superplot toggle is checked.
- Add a release note entry describing the corrected documentation link.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| qt/python/mantidqt/mantidqt/plotting/figuretype.py | Adds a FigureType enum entry for Superplot. |
| qt/applications/workbench/workbench/plotting/toolbar.py | Emits a different signal from Help when Superplot is toggled on. |
| qt/applications/workbench/workbench/plotting/plothelppages.py | Adds Superplot help URL and a superplot flag to select it. |
| qt/applications/workbench/workbench/plotting/figuremanager.py | Connects the new toolbar signal to a Superplot help launcher. |
| docs/source/release/v6.16.0/Workbench/Bugfixes/38044.rst | Release note for the Superplot help link fix. |
You can also share your feedback on Copilot code review. Take the survey.
jclarkeSTFC
requested changes
Mar 19, 2026
Contributor
jclarkeSTFC
left a comment
There was a problem hiding this comment.
It's works well, but I think the comments from Copilot are worth addressing
fb84403 to
8867b2d
Compare
jclarkeSTFC
approved these changes
Mar 19, 2026
Contributor
jclarkeSTFC
left a comment
There was a problem hiding this comment.
Thanks for making those changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Closes #38044 .
To test:
ws = CreateSampleWorkspace()Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
mantid-developersormantid-contributorsteams, add a review commentrerun cito authorize/rerun the CIGatekeeper
As per the gatekeeping guidelines: