Skip to content

Set minimum python version to 3.12 in CMake#41087

Merged
MialLewis merged 1 commit intomainfrom
set_python_3_12_cmake_min
Mar 19, 2026
Merged

Set minimum python version to 3.12 in CMake#41087
MialLewis merged 1 commit intomainfrom
set_python_3_12_cmake_min

Conversation

@jclarkeSTFC
Copy link
Contributor

@jclarkeSTFC jclarkeSTFC commented Mar 19, 2026

Also updated copilot instructions and codebase analysis to reflect this change.

Hopefully this sorts out recent CI problems.

Here the ${_res_py_content} variable is empty, presumable because the command above isn't working, which I think is due to PYRCC5_CMD being incorrect, which may be due to the wrong min Python version in the cmake.

To test:


Reviewer

Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.

As per the review guidelines:

  • Is the code of an acceptable quality? (Code standards/GUI standards)
  • Has a thorough functional test been performed? Do the changes handle unexpected input/situations?
  • Are appropriately scoped unit and/or system tests provided?
  • Do the release notes conform to the guidelines and describe the changes appropriately?
  • Has the relevant (user and developer) documentation been added/updated?
  • If the PR author isn’t in the mantid-developers or mantid-contributors teams, add a review comment rerun ci to authorize/rerun the CI

Gatekeeper

As per the gatekeeping guidelines:

  • Has a thorough first line review been conducted, including functional testing?
  • At a high-level, is the code quality sufficient?
  • Are the base, milestone and labels correct?

Also updated copilot instructions and codebase analysis to reflect this
change.
@jclarkeSTFC jclarkeSTFC added this to the Release 6.16 milestone Mar 19, 2026
@jclarkeSTFC jclarkeSTFC added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions labels Mar 19, 2026
@jclarkeSTFC jclarkeSTFC marked this pull request as ready for review March 19, 2026 15:03
@MialLewis MialLewis enabled auto-merge (squash) March 19, 2026 15:20
@github-actions
Copy link
Contributor

Unit test results

2 861 tests   2 861 ✅  12h 41m 18s ⏱️
    1 suites      0 💤
    1 files        0 ❌

Results for commit 3956293.

@github-actions
Copy link
Contributor

System test results

808 tests   792 ✅  3h 3m 40s ⏱️
 11 suites   16 💤
 11 files      0 ❌

Results for commit 3956293.

@MialLewis MialLewis merged commit 90a170b into main Mar 19, 2026
12 checks passed
@MialLewis MialLewis deleted the set_python_3_12_cmake_min branch March 19, 2026 17:38
peterfpeterson pushed a commit to peterfpeterson/mantid that referenced this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority An issue or pull request that if not addressed is severe enough to postponse a release. ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants