Set minimum python version to 3.12 in CMake#41087
Merged
Conversation
Also updated copilot instructions and codebase analysis to reflect this change.
jhaigh0
approved these changes
Mar 19, 2026
Contributor
Unit test results2 861 tests 2 861 ✅ 12h 41m 18s ⏱️ Results for commit 3956293. |
Contributor
System test results808 tests 792 ✅ 3h 3m 40s ⏱️ Results for commit 3956293. |
peterfpeterson
pushed a commit
to peterfpeterson/mantid
that referenced
this pull request
Mar 19, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updated copilot instructions and codebase analysis to reflect this change.
Hopefully this sorts out recent CI problems.
Here the
${_res_py_content}variable is empty, presumable because the command above isn't working, which I think is due toPYRCC5_CMDbeing incorrect, which may be due to the wrong min Python version in the cmake.To test:
Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
mantid-developersormantid-contributorsteams, add a review commentrerun cito authorize/rerun the CIGatekeeper
As per the gatekeeping guidelines: