Skip to content

Define project metadata for sip#41091

Open
peterfpeterson wants to merge 1 commit intomantidproject:mainfrom
peterfpeterson:sip_metadata
Open

Define project metadata for sip#41091
peterfpeterson wants to merge 1 commit intomantidproject:mainfrom
peterfpeterson:sip_metadata

Conversation

@peterfpeterson
Copy link
Member

@peterfpeterson peterfpeterson commented Mar 19, 2026

This add metadata so sip will stop creating the error message

14:25:35 sip-build: pyproject.toml: the '[tool.sip.metadata]' section is missing
14:25:35 CMake Warning at buildconfig/CMake/FindSIP.cmake:110 (message):
14:25:35   FindSIP failed to determine sip version
14:25:35 Call Stack (most recent call first):
14:25:35   CMakeLists.txt:136 (find_package)

There is no associate issue

To test:

Look at the build logs and see that the version of sip is logged from cmake rather than the error that is listed above.

This does not require release notes because it only gets rid of a warning in the builds.


Reviewer

Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.

As per the review guidelines:

  • Is the code of an acceptable quality? (Code standards/GUI standards)
  • Has a thorough functional test been performed? Do the changes handle unexpected input/situations?
  • Are appropriately scoped unit and/or system tests provided?
  • Do the release notes conform to the guidelines and describe the changes appropriately?
  • Has the relevant (user and developer) documentation been added/updated?
  • If the PR author isn’t in the mantid-developers or mantid-contributors teams, add a review comment rerun ci to authorize/rerun the CI

Gatekeeper

As per the gatekeeping guidelines:

  • Has a thorough first line review been conducted, including functional testing?
  • At a high-level, is the code quality sufficient?
  • Are the base, milestone and labels correct?

@peterfpeterson peterfpeterson added this to the Release 6.16 milestone Mar 19, 2026
@peterfpeterson peterfpeterson marked this pull request as ready for review March 20, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant