Define project metadata for sip#41091
Open
peterfpeterson wants to merge 1 commit intomantidproject:mainfrom
Open
Define project metadata for sip#41091peterfpeterson wants to merge 1 commit intomantidproject:mainfrom
peterfpeterson wants to merge 1 commit intomantidproject:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add metadata so sip will stop creating the error message
14:25:35 sip-build: pyproject.toml: the '[tool.sip.metadata]' section is missing 14:25:35 CMake Warning at buildconfig/CMake/FindSIP.cmake:110 (message): 14:25:35 FindSIP failed to determine sip version 14:25:35 Call Stack (most recent call first): 14:25:35 CMakeLists.txt:136 (find_package)There is no associate issue
To test:
Look at the build logs and see that the version of sip is logged from cmake rather than the error that is listed above.
This does not require release notes because it only gets rid of a warning in the builds.
Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
mantid-developersormantid-contributorsteams, add a review commentrerun cito authorize/rerun the CIGatekeeper
As per the gatekeeping guidelines: