Skip to content

check the range is not empty in sequential fit dialog#41132

Merged
SilkeSchomann merged 2 commits intomainfrom
range_nonempty
Mar 27, 2026
Merged

check the range is not empty in sequential fit dialog#41132
SilkeSchomann merged 2 commits intomainfrom
range_nonempty

Conversation

@jmborr
Copy link
Copy Markdown
Member

@jmborr jmborr commented Mar 26, 2026

Description of work

Added additional check so that isValidRangeFormat only executed for non-empty ranges. Otherwise it breaks all the sequential fits that do not use this input.

Addresses EWM 15793

Release notes not necessary since this is a small change, and unnoticiable by the user.

To test:


Reviewer

Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.

As per the review guidelines:

  • Is the code of an acceptable quality? (Code standards/GUI standards)
  • Has a thorough functional test been performed? Do the changes handle unexpected input/situations?
  • Are appropriately scoped unit and/or system tests provided?
  • Do the release notes conform to the guidelines and describe the changes appropriately?
  • Has the relevant (user and developer) documentation been added/updated?
  • If the PR author isn’t in the mantid-developers or mantid-contributors teams, add a review comment rerun ci to authorize/rerun the CI

Gatekeeper

As per the gatekeeping guidelines:

  • Has a thorough first line review been conducted, including functional testing?
  • At a high-level, is the code quality sufficient?
  • Are the base, milestone and labels correct?

@jmborr jmborr self-assigned this Mar 26, 2026
@github-actions github-actions bot added this to the Release 6.16 milestone Mar 26, 2026
@jmborr jmborr added the Framework Issues and pull requests related to components in the Framework label Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

Unit test results

2 863 tests   2 863 ✅  13h 11m 49s ⏱️
    1 suites      0 💤
    1 files        0 ❌

Results for commit c757e91.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

System test results

808 tests   792 ✅  3h 1m 36s ⏱️
 11 suites   16 💤
 11 files      0 ❌

Results for commit c757e91.

♻️ This comment has been updated with latest results.

This comment was marked as resolved.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@SilkeSchomann SilkeSchomann self-assigned this Mar 27, 2026
@SilkeSchomann SilkeSchomann merged commit 7e925eb into main Mar 27, 2026
14 checks passed
@jmborr jmborr deleted the range_nonempty branch March 27, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Framework Issues and pull requests related to components in the Framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants