check the range is not empty in sequential fit dialog#41132
Merged
SilkeSchomann merged 2 commits intomainfrom Mar 27, 2026
Merged
check the range is not empty in sequential fit dialog#41132SilkeSchomann merged 2 commits intomainfrom
SilkeSchomann merged 2 commits intomainfrom
Conversation
Contributor
Unit test results2 863 tests 2 863 ✅ 13h 11m 49s ⏱️ Results for commit c757e91. ♻️ This comment has been updated with latest results. |
Contributor
System test results808 tests 792 ✅ 3h 1m 36s ⏱️ Results for commit c757e91. ♻️ This comment has been updated with latest results. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rosswhitfield
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Added additional check so that
isValidRangeFormatonly executed for non-empty ranges. Otherwise it breaks all the sequential fits that do not use this input.Addresses EWM 15793
Release notes not necessary since this is a small change, and unnoticiable by the user.
To test:
Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
mantid-developersormantid-contributorsteams, add a review commentrerun cito authorize/rerun the CIGatekeeper
As per the gatekeeping guidelines: