Open
Conversation
is ready. Still only supporting simulated data for now. Updated tests after merging in main as this branch was very far behind
Contributor
Unit test results2 863 tests 2 863 ✅ 1h 56m 27s ⏱️ Results for commit 9581f5c. |
Contributor
System test results808 tests 792 ✅ 2h 4m 49s ⏱️ Results for commit 9581f5c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
This is to add loading logic mainly for MIDAS data. No new logic was added for WAND data as HFIRPowderReduction just calls LoadWAND when WAND data is supplied. Loading MIDAS data is similar to LoadWAND, however we do not worry about grouping for MIDAS. Also, masking values will need to be updated later once the actual instrument is built. The new logic for loading is not used yet as we still only have simulated MIDAS data.
EWM item 13307
To test:
Just make sure you can still perform reduction with both MIDAS and WAND data. See the test steps at #41055 for info on performing reduction.
Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
mantid-developersormantid-contributorsteams, add a review commentrerun cito authorize/rerun the CIGatekeeper
As per the gatekeeping guidelines: