Skip to content

HFIRPowderReduction load backend#41137

Open
dlcaballero16 wants to merge 4 commits intomainfrom
hfirpowderreduction-load-backend
Open

HFIRPowderReduction load backend#41137
dlcaballero16 wants to merge 4 commits intomainfrom
hfirpowderreduction-load-backend

Conversation

@dlcaballero16
Copy link
Copy Markdown
Contributor

Description of work

This is to add loading logic mainly for MIDAS data. No new logic was added for WAND data as HFIRPowderReduction just calls LoadWAND when WAND data is supplied. Loading MIDAS data is similar to LoadWAND, however we do not worry about grouping for MIDAS. Also, masking values will need to be updated later once the actual instrument is built. The new logic for loading is not used yet as we still only have simulated MIDAS data.

EWM item 13307

To test:

Just make sure you can still perform reduction with both MIDAS and WAND data. See the test steps at #41055 for info on performing reduction.


Reviewer

Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.

As per the review guidelines:

  • Is the code of an acceptable quality? (Code standards/GUI standards)
  • Has a thorough functional test been performed? Do the changes handle unexpected input/situations?
  • Are appropriately scoped unit and/or system tests provided?
  • Do the release notes conform to the guidelines and describe the changes appropriately?
  • Has the relevant (user and developer) documentation been added/updated?
  • If the PR author isn’t in the mantid-developers or mantid-contributors teams, add a review comment rerun ci to authorize/rerun the CI

Gatekeeper

As per the gatekeeping guidelines:

  • Has a thorough first line review been conducted, including functional testing?
  • At a high-level, is the code quality sufficient?
  • Are the base, milestone and labels correct?

@github-actions github-actions bot added this to the Release 6.16 milestone Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Unit test results

2 863 tests   2 863 ✅  1h 56m 27s ⏱️
    1 suites      0 💤
    1 files        0 ❌

Results for commit 9581f5c.

@github-actions
Copy link
Copy Markdown
Contributor

System test results

808 tests   792 ✅  2h 4m 49s ⏱️
 47 suites   16 💤
 47 files      0 ❌

Results for commit 9581f5c.

@dlcaballero16 dlcaballero16 added Diffraction Issues and pull requests related to diffraction ORNL Team Issues and pull requests managed by the ORNL development team labels Mar 26, 2026
@dlcaballero16 dlcaballero16 marked this pull request as ready for review March 26, 2026 17:28
@peterfpeterson peterfpeterson added the Powder Issues and pull requests related to powder diffraction label Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Diffraction Issues and pull requests related to diffraction ORNL Team Issues and pull requests managed by the ORNL development team Powder Issues and pull requests related to powder diffraction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants