Skip to content

Commit 34ffe85

Browse files
committed
refactor: fix benchmarks and C code style for normal/cdf
1 parent dd0aab8 commit 34ffe85

File tree

3 files changed

+19
-30
lines changed

3 files changed

+19
-30
lines changed

lib/node_modules/@stdlib/stats/base/dists/normal/cdf/benchmark/benchmark.js

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
var bench = require( '@stdlib/bench' );
2424
var Float64Array = require( '@stdlib/array/float64' );
2525
var uniform = require( '@stdlib/random/array/uniform' );
26-
var randu = require( '@stdlib/random/base/randu' );
2726
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2827
var EPS = require( '@stdlib/constants/float64/eps' );
2928
var pkg = require( './../package.json' ).name;
@@ -41,14 +40,9 @@ bench( pkg, function benchmark( b ) {
4140
var i;
4241

4342
len = 100;
44-
x = new Float64Array( len );
45-
mu = new Float64Array( len );
46-
sigma = new Float64Array( len );
47-
for ( i = 0; i < len; i++ ) {
48-
x[ i ] = ( randu() * 200.0 ) - 100.0;
49-
mu[ i ] = ( randu() * 100.0 ) - 50.0;
50-
sigma[ i ] = ( randu() * 20.0 ) + EPS;
51-
}
43+
x = uniform( len, -100.0, 100.0 );
44+
mu = uniform( len, -50.0, 50.0 );
45+
sigma = uniform( len, EPS, 20.0 + EPS );
5246

5347
b.tic();
5448
for ( i = 0; i < b.iterations; i++ ) {

lib/node_modules/@stdlib/stats/base/dists/normal/cdf/benchmark/benchmark.native.js

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
2525
var Float64Array = require( '@stdlib/array/float64' );
26-
var randu = require( '@stdlib/random/base/randu' );
26+
var uniform = require( '@stdlib/random/array/uniform' );
2727
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2828
var tryRequire = require( '@stdlib/utils/try-require' );
2929
var EPS = require( '@stdlib/constants/float64/eps' );
@@ -49,14 +49,9 @@ bench( pkg, opts, function benchmark( b ) {
4949
var i;
5050

5151
len = 100;
52-
x = new Float64Array( len );
53-
mu = new Float64Array( len );
54-
sigma = new Float64Array( len );
55-
for ( i = 0; i < len; i++ ) {
56-
x[ i ] = ( randu() * 200.0 ) - 100.0;
57-
mu[ i ] = ( randu() * 100.0 ) - 50.0;
58-
sigma[ i ] = ( randu() * 20.0 ) + EPS;
59-
}
52+
x = uniform( len, -100.0, 100.0 );
53+
mu = uniform( len, -50.0, 50.0 );
54+
sigma = uniform( len, EPS, 20.0 + EPS );
6055

6156
b.tic();
6257
for ( i = 0; i < b.iterations; i++ ) {

lib/node_modules/@stdlib/stats/base/dists/normal/cdf/src/main.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -31,28 +31,28 @@
3131
* @return evaluated cumulative distribution function
3232
*
3333
* @example
34-
* double y = stdlib_base_arcsine_cdf( 2.0, 0.0, 1.0 );
34+
* double y = stdlib_base_dists_normal_cdf( 2.0, 0.0, 1.0 );
3535
* // returns ~0.977
3636
*/
3737
double stdlib_base_dists_normal_cdf( const double x, const double mu, const double sigma ) {
3838

3939
double denom;
40-
double xc;
40+
double xc;
4141

4242
if (
43-
stdlib_base_is_nan( x ) ||
44-
stdlib_base_is_nan( mu ) ||
45-
stdlib_base_is_nan( sigma ) ||
46-
sigma < 0.0
47-
) {
48-
return 0.0/0.0; // NaN
49-
}
43+
stdlib_base_is_nan( x ) ||
44+
stdlib_base_is_nan( mu ) ||
45+
stdlib_base_is_nan( sigma ) ||
46+
sigma < 0.0
47+
) {
48+
return 0.0/0.0; // NaN
49+
}
5050
if ( sigma == 0.0 ) {
51-
return (x < mu) ? 0.0 : 1.0;
52-
}
51+
return (x < mu) ? 0.0 : 1.0;
52+
}
5353

5454
denom = sigma * stdlib_base_sqrt( 2.0 );
55-
xc = x - mu;
55+
xc = x - mu;
5656

5757
return 0.5 * stdlib_base_erfc( -xc / denom );
5858
}

0 commit comments

Comments
 (0)