Skip to content

Fix value counts SQL columns #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manzt merged 1 commit into from
Jul 30, 2025
Merged

Fix value counts SQL columns #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/clients/ValueCounts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,16 +68,20 @@ export class ValueCounts extends MosaicClient {
}

override query(filter: Array<ExprNode> = []): Query {
let col = column(this.#column);
let counts = Query
.from({ source: this.#table })
.select({
value: sql`CASE
WHEN ${column(this.#column)} IS NULL THEN '__quak_null__'
ELSE ${column(this.#column)}
WHEN ${col} IS NULL THEN '__quak_null__'
ELSE CAST(${col} AS VARCHAR)
END`,
count: count(),
})
.groupby("value")
.groupby(sql`CASE
WHEN ${col} IS NULL THEN '__quak_null__'
ELSE CAST(${col} AS VARCHAR)
END`)
.where(filter);
return Query
.with({ counts })
Expand Down