Skip to content

Remove workaround for mosaic client updates (and flickering in UI) #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manzt merged 1 commit into from
Aug 1, 2025
Merged

Remove workaround for mosaic client updates (and flickering in UI) #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions lib/clients/ValueCounts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {
column,
count,
type ExprNode,
type MaybeArray,
Query,
sql,
sum,
Expand All @@ -18,7 +17,6 @@ import { effect } from "@preact/signals-core";

import { ValueCountsPlot } from "../utils/ValueCountsPlot.ts";
import { assert } from "../utils/assert.ts";
import { isFlechetteTable } from "../utils/guards.ts";

interface UniqueValuesOptions {
/** The table to query. */
Expand All @@ -43,28 +41,6 @@ export class ValueCounts extends MosaicClient {
this.#table = options.table;
this.#column = options.field.name;
this.#field = options.field;

// FIXME: There is some issue with the mosaic client or the query we
// are using here. Updates to the Selection (`filterBy`) seem to be
// missed by the coordinator, and query/queryResult are not called
// by the coordinator when the filterBy is updated.
//
// Here we manually listen for the changes to filterBy and update this
// client internally. It _should_ go through the coordinator.
options.filterBy.addEventListener("value", async () => {
if (!this.#plot || !this.coordinator) {
return;
}
let filters = options.filterBy.predicate(this);
assert(
isExprNodeArray(filters),
`Filter is not expression array: ${filters}`,
);
let query = this.query(filters);
let data = await this.coordinator.query(query);
assert(isFlechetteTable(data), "Expected a flechette table.");
this.#plot.data.value = data;
});
}

override query(filter: Array<ExprNode> = []): Query {
Expand Down Expand Up @@ -130,9 +106,3 @@ export class ValueCounts extends MosaicClient {
};
}
}

function isExprNodeArray(
x: MaybeArray<string | boolean | undefined | ExprNode>,
): x is Array<ExprNode> {
return Array.isArray(x) && x.every((y) => typeof y === "object");
}