-
Notifications
You must be signed in to change notification settings - Fork 8
add export functionality #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
frwg
wants to merge
11
commits into
develop
Choose a base branch
from
feature/addExportFunctionality2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8ddc2a7
add export functionality
frwg 69884ab
Update CHANGELOG.md
frwg 340e580
Update CHANGELOG.md
frwg 37d3062
Fix link in changelog
Phocacius 8019482
Add Font Awesome 6 styling for sort icons
Phocacius 6395c08
adjust layout of export checkbox
frwg 9da74fd
adjust layout of export icon
frwg 41f26ff
adjust toolgroup for export icon
frwg 1ed4631
remove trailing tbody > tr
frwg fb63adc
add Translations
frwg fcd2ce8
fix two missing translations in russian
frwg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,7 +71,7 @@ | |
| return (!seen[toolSpec.type]) | ||
| && self.checkToolAccess_(subSchemas[s], toolSpec.type) | ||
| && -1 !== validNames.indexOf(toolSpec.type) | ||
| ; | ||
| ; | ||
| }); | ||
| for (var t = 0; t < subSchemaTools.length; ++t) { | ||
| var toolSpec = subSchemaTools[t]; | ||
|
|
@@ -102,10 +102,22 @@ | |
| .append($icon) | ||
| .data({ | ||
| schema: btnSchema | ||
| }) | ||
| ; | ||
| }); | ||
| buttons.push($button); | ||
| } | ||
|
|
||
| if (schema.allowGeometryExport || this.owner.expandCombination(schema).some(subSchema => subSchema.allowGeometryExport)) { | ||
| var $exportBtnIcon = $('<span>').addClass('fa fa-download'); | ||
| var $exportBtn = $('<button>') | ||
| .attr({ | ||
| type: 'button', | ||
| title: Mapbender.trans('mb.digitizer.toolset.exportSelected') | ||
| }) | ||
| .addClass('btn btn-default -fn-export-selected') | ||
|
||
| .append($exportBtnIcon); | ||
| buttons.push($exportBtn); | ||
| } | ||
|
|
||
| return buttons; | ||
| }, | ||
| checkToolAccess_: function(schema, toolName) { | ||
|
|
@@ -126,6 +138,45 @@ | |
| } | ||
| }); | ||
| }); | ||
|
|
||
| // Add an event listener for exporting the currently selected features | ||
| widget.element.on('click', '.-fn-export-selected', function() { | ||
| // Get the selected features | ||
| var exportFeatures = widget.tableRenderer.selectedFeatures || []; | ||
|
|
||
| // Check if there are any features to export | ||
| if (exportFeatures.length === 0) { | ||
| $.notify(Mapbender.trans('mb.digitizer.feature.export.notFound')); | ||
| return; | ||
| } | ||
|
|
||
| // Create a new array of features that include geometry and properties | ||
| var strippedFeatures = exportFeatures.map(function(originalFeature) { | ||
| var geometryClone = originalFeature.getGeometry().clone(); | ||
| var properties = originalFeature.get("data"); | ||
| delete properties.geometry; // Remove the geometry property to avoid duplication | ||
| return new ol.Feature({ | ||
| geometry: geometryClone, | ||
| ...properties // Add the properties to the new feature | ||
| }); | ||
| }); | ||
|
|
||
| var format = new ol.format.GeoJSON(); | ||
| var dataProjection = 'EPSG:4326'; | ||
|
|
||
| // Write features as GeoJSON, specifying only geometry | ||
| var geojson = format.writeFeaturesObject(strippedFeatures, { | ||
| dataProjection: dataProjection, | ||
| featureProjection: widget.mbMap.getModel().olMap.getView().getProjection() | ||
| }); | ||
|
|
||
|
|
||
| widget.createExportData(geojson); | ||
|
|
||
|
|
||
|
|
||
| }); | ||
|
|
||
| } | ||
| }; | ||
| })(jQuery); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the specific tbody > tr and not just the .fn-check-for-export?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because I did not want to break the pattern used for the other click events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I see. I'd vote for removing the tbody > tr for all of the click listeners, the more separation between markup and logic the more maintainable the code