Fix build and test with modern compilers

.github/workflows/ci.yml

@@ -0,0 +1,26 @@
+name: ci
+
+on:
+  push:
+
+  pull_request:
+    branches:
+      - "*"
+
+jobs:
+  build:
+    runs-on: ubuntu-24.04
+
+    strategy:
+      matrix:
+        compiler: [clang++-16, clang++-17, clang++-18, g++-12, g++-13, g++-14]
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Build with ${{ matrix.compiler }}
+        env:
+          CXX: ${{ matrix.compiler }}
+        run: |
+          make clean
+          make test examples

Makefile

@@ -4,13 +4,29 @@ BUILD := build/$(VARIANT)
 COMPILER := $(shell CXX="${CXX}" misc/compiler.sh)
 COMPILER_MAJOR_VERSION := $(shell CXX="${CXX}" misc/compiler-major-version.sh)
 
+COMMON_WARNINGS := \
+    -Wall \
+    -Wextra \
+    -pedantic \
+    -Wno-unused-but-set-variable \
+    -Wno-switch-default \
+    -Wno-cast-function-type
+
 ifeq ($(COMPILER), clang)
-	CXXFLAGS_WARNINGS := -Weverything -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-exit-time-destructors
-	ifeq ($(shell test $(COMPILER_MAJOR_VERSION) -gt 4; echo $$?),0)
-		CXXFLAGS_WARNINGS += -Wno-unused-template
-	endif
+  CXXFLAGS_WARNINGS := \
+    $(COMMON_WARNINGS) \
+    -Weverything \
+    -Wno-c++98-compat \
+    -Wno-c++98-compat-pedantic \
+    -Wno-exit-time-destructors \
+    -Wno-unused-template \
+    -Wno-poison-system-directories \
+    -Wno-cast-function-type-strict \
+    -Wno-shadow-field \
+    -Wno-reserved-identifier \
+    -Wno-unsafe-buffer-usage
 else ifeq ($(COMPILER), gcc)
-	CXXFLAGS_WARNINGS := -Wall -Wextra -pedantic -Wno-unused-but-set-variable
+  CXXFLAGS_WARNINGS := $(COMMON_WARNINGS)
 endif
 
 CXXFLAGS := $(CXXFLAGS) --std=c++14 -fPIC -Iinclude $(CXXFLAGS_WARNINGS) -Werror

examples/NativePeer.java

@@ -19,7 +19,6 @@ public static void main(String[] args) {
         System.out.println("2 + 2 = " + calculator.add(2, 2));
         System.out.println("8 - 4 = " + calculator.subtract(8, 4));
 
-        // You wouldn't normally use this; it's here to show that the native finalizer does get executed.
-        System.runFinalizersOnExit(true);
+        // the native finalizer will get executed
     }
 }

include/jni/native_method.hpp

@@ -196,9 +196,9 @@ namespace jni
             template < class Peer, class TagType, class = std::enable_if_t< std::is_same<P, Peer>::value > >
             auto operator()(const Field<TagType, jlong>& field)
                {
-                auto wrapper = [field, lambda = lambda] (JNIEnv& env, Object<TagType>& obj, Args... args)
+                auto wrapper = [field, currLambda = lambda] (JNIEnv& env, Object<TagType>& obj, Args... args)
                    {
-                    return lambda(env, *reinterpret_cast<P*>(obj.Get(env, field)), args...);
+                    return currLambda(env, *reinterpret_cast<P*>(obj.Get(env, field)), args...);
                    };
 
                 return MakeNativeMethod(name, wrapper);

include/jni/string_conversion.hpp

@@ -7,6 +7,9 @@
 #include <locale>
 #include <codecvt>
 
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+
 namespace jni
    {
     inline std::u16string convertUTF8ToUTF16(const std::string& string)
@@ -19,3 +22,5 @@ namespace jni
         return std::wstring_convert<std::codecvt_utf8_utf16<char16_t>, char16_t>().to_bytes(string);
        }
    }
+
+#pragma GCC diagnostic pop