Fix turfVersion type and script to set version for SPM test #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aleksproger
commented
Nov 12, 2024
aleksproger
commented
- Fixed the script to set version for SwiftPM properly
- Added the type for turfVersion(made PR in mapbox-sdk as well to fix template)
aleksproger
commented
Nov 12, 2024
| MapboxCommon: | ||
| url: [email protected]:mapbox/mapbox-common-ios.git | ||
| branch: release-v24.0.0-rc.2 | ||
| branch: v24.9.0-daily-2024-11-12-04-00 |
Contributor
Author
There was a problem hiding this comment.
Created a dummy branch with the fix to turfVersion so the test may pass
Otherwise with 24.9.0-daily-2024-11-12-04-26 it will fail
It will be overwritten with proper version with first daily release
kried
approved these changes
Nov 12, 2024
DorkMatter
reviewed
Nov 13, 2024
olegfedorovdev
approved these changes
Nov 13, 2024
aleksproger
force-pushed
the
fix-turf-version/0
branch
from
a160942 to
7b976bd
Compare
aleksproger
force-pushed
the
fix-turf-version/0
branch
from
7b976bd to
a0a1bf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.