[GLJS-1346] Add option to support browser focus #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underoot
force-pushed
the
underoot/GLJS-1346
branch
2 times, most recently
from
9fcdd1a to
a016e9d
Compare
underoot
changed the title
Introduce `useBrowserFocus` option, which preserves backward compatibility and gives a user access to the suggestion list with a keyboard with respecting the default browser focus behaviour.
underoot
force-pushed
the
underoot/GLJS-1346
branch
2 times, most recently
from
59811bd to
c1fc77e
Compare
underoot
force-pushed
the
underoot/GLJS-1346
branch
from
c1fc77e to
f8644d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
useBrowserFocusoption, which preserves backward compatibility (default isfalse) and gives a user access to the suggestion list with a keyboard while respecting the default browser focus behaviour. (Have a look at the video)Add tests to CI. Some tests have been failing on
main, so for some I've updated expectations, but for some I have to ignore them.GLJS-1346.mov
npm run docsand commit changes to API.mdmasterheading before merging