Skip to content

Conversation

@miafan23
Copy link
Contributor

@miafan23 miafan23 commented Dec 16, 2025

The Mapbox API knows the SDK version for v3+, so we could allow users to add properties to the source to override TileJSON values for GL JS v3+.

Launch Checklist

  • Make sure the PR title is descriptive and preferably reflects the change from the user's perspective.
  • Add additional detail and context in the PR description (with screenshots/videos if there are visual changes).
  • Manually test the debug page.
  • Write tests for all new functionality and make sure the CI checks pass.
  • Document any changes to public APIs.
  • Post benchmark scores if the change could affect performance.
  • Tag @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes.
  • Tag @mapbox/gl-native if this PR includes shader changes or needs a native port.
  • Tag @mapbox/gl-native if this PR disables any test because it also needs to be disabled on their side.
  • Create a ticket for gl-native to groom in the MAPSNAT JIRA queue if this PR includes shader changes or features not present in the native side or if it disables a test that's not disabled there.

@miafan23 miafan23 marked this pull request as ready for review December 16, 2025 14:27
@miafan23 miafan23 requested a review from a team as a code owner December 16, 2025 14:27
@miafan23 miafan23 merged commit fead114 into main Dec 16, 2025
9 checks passed
@miafan23 miafan23 deleted the remove-source-property-check branch December 16, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants