Skip to content

Commit 9e06604

Browse files
jushgithub-actions[bot]
authored andcommitted
Remove unused pitest plugin (#4637)
Long time ago we integrated pitest for compass plugin: #1358 But it was never really used and not extended to other tests so this PR removes it (it also helps with migration to newer AGP/Gradle) cc @mapbox/maps-android GitOrigin-RevId: 073c014c538f2bb2d50b9f554a02874aab4b62b4
1 parent fd0116f commit 9e06604

File tree

5 files changed

+0
-52
lines changed

5 files changed

+0
-52
lines changed

DEVELOPING.md

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -209,22 +209,6 @@ Unit tests, for all modules, can be run locally with:
209209
$ make unit-tests
210210
```
211211

212-
### Mutation tests
213-
214-
Mutation testing is a technique used to check quality of unit tests and improve them.
215-
The main idea is to change the production code and cause the tests to fail.
216-
Each mutated version is called a mutant and tests detect and reject mutants by causing the behavior
217-
of the original version to differ from the mutant.
218-
Read more about [mutation testing](https://en.wikipedia.org/wiki/Mutation_testing).
219-
For generating mutants on the JVM we are using [Pitest](http://pitest.org/) library.
220-
221-
Because of such testing type takes lot of time you can only run it on necessary module:
222-
223-
```
224-
$ ./gradlew plugin-compass:pitestDebug
225-
```
226-
227-
228212
### Instrumentation tests
229213

230214
Instrumentation tests are integration test that validate the integration with the Android OS and

build.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ buildscript {
2626
classpath(libs.plugin.mapbox.sdkRegistry)
2727
classpath(libs.plugin.mapbox.sdkVersions)
2828
classpath(libs.plugin.mapbox.ndk)
29-
classpath(libs.plugin.pitest)
3029
classpath(libs.plugin.playPublisher)
3130
classpath(libs.plugin.gradleVersions)
3231
}

gradle/libs.versions.toml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ pluginMapboxAccessToken = "0.4.0"
2121
pluginMapboxSdkRegistry = "1.3.3"
2222
pluginMapboxSdkVersions = "1.1.3"
2323
pluginMapboxNdk = "0.1.0"
24-
pluginPitest = "0.2.8"
2524
pluginTaskTree = "2.1.0"
2625
pluginPlayPublisher = "3.7.0"
2726
pluginGradleVersions = "0.42.0"
@@ -106,7 +105,6 @@ plugin-mapbox-sdkRegistry = { module = "com.mapbox.gradle.plugins:sdk-registry",
106105
plugin-mapbox-sdkVersions = { module = "com.mapbox.mapboxsdk:mapbox-android-sdk-versions", version.ref = "pluginMapboxSdkVersions" }
107106
plugin-mapbox-ndk = { module = "com.mapbox.gradle.plugins:ndk", version.ref = "pluginMapboxNdk" }
108107

109-
plugin-pitest = { module = "pl.droidsonroids.gradle:gradle-pitest-plugin", version.ref = "pluginPitest" }
110108
plugin-playPublisher = { module = "com.github.triplet.gradle:play-publisher", version.ref = "pluginPlayPublisher" }
111109
plugin-gradleVersions = { module = "com.github.ben-manes:gradle-versions-plugin", version.ref = "pluginGradleVersions" }
112110

@@ -158,7 +156,6 @@ junit = { module = "junit:junit", version.ref = "junit" }
158156
kotlin = { module = "org.jetbrains.kotlin:kotlin-stdlib-jdk8", version.ref = "kotlin" }
159157
kotlinDataCompatAnnotation = { module = "com.github.tobrun.kotlin-data-compat:annotation", version.ref = "kotlinDataCompat" }
160158
kotlinDataCompatProcessor = { module = "com.github.tobrun.kotlin-data-compat:processor", version.ref = "kotlinDataCompat" }
161-
kotlinReflect = { module = "org.jetbrains.kotlin:kotlin-reflect", version.ref = "kotlin" }
162159
lint = { module = "com.android.tools.lint:lint", version.ref = "lint" }
163160
lintApi = { module = "com.android.tools.lint:lint-api", version.ref = "lint" }
164161
lintChecks = { module = "com.android.tools.lint:lint-checks", version.ref = "lint" }
@@ -173,8 +170,6 @@ mapbox-javaTurf = { module = "com.mapbox.mapboxsdk:mapbox-sdk-turf", version.ref
173170
mapbox-services = { module = "com.mapbox.mapboxsdk:mapbox-sdk-services", version.ref = "mapboxJavaServices" }
174171

175172
mockk = { module = "io.mockk:mockk", version.ref = "mockk" }
176-
mockkAgentApi = { module = "io.mockk:mockk-agent-api", version.ref = "mockk" }
177-
mockkAgentJvm = { module = "io.mockk:mockk-agent-jvm", version.ref = "mockk" }
178173

179174
robolectric = { module = "org.robolectric:robolectric", version.ref = "robolectric" }
180175
robolectricEgl = { module = "org.khronos:opengl-api", version.ref = "robolectricEgl" }

gradle/pitest.gradle

Lines changed: 0 additions & 21 deletions
This file was deleted.

plugin-compass/build.gradle.kts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,6 @@ dependencies {
2727
implementation(libs.bundles.base.dependencies)
2828

2929
testImplementation(libs.bundles.base.dependenciesTests)
30-
testImplementation(libs.mockkAgentApi)
31-
testImplementation(libs.mockkAgentJvm)
32-
testImplementation(libs.kotlinReflect)
3330
testImplementation(project(":plugin-animation"))
3431

3532
androidTestImplementation(libs.bundles.base.dependenciesAndroidTests)
@@ -42,12 +39,6 @@ project.apply {
4239
from("$rootDir/gradle/ktlint.gradle")
4340
from("$rootDir/gradle/lint.gradle")
4441
from("$rootDir/gradle/track-public-apis.gradle")
45-
from("$rootDir/gradle/pitest.gradle")
4642
from("$rootDir/gradle/detekt.gradle")
4743
from("$rootDir/gradle/dependency-updates.gradle")
4844
}
49-
50-
configure<pl.droidsonroids.gradle.pitest.PitestPluginExtension> {
51-
targetClasses.set(listOf("com.mapbox.maps.plugin.compass**"))
52-
targetTests.set(listOf("**Compass**"))
53-
}

0 commit comments

Comments
 (0)