[Core] Route refresh integration test #4802
Open
+3,352
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemStepuk
changed the title
kried
reviewed
Nov 3, 2025
| ] | ||
| ), | ||
| .testTarget( | ||
| name: "MapboxCoreNavigationIntegrationTests", |
There was a problem hiding this comment.
When added as a test target, these tests will be run as a part of required job, as a MapboxNavigation-Package step
Comment on lines
+266
to
+267
| let mappedUrlItem = queryItems!.first(where: { $0 == .customItem })! | ||
| self.customParameters = [mappedUrlItem] |
There was a problem hiding this comment.
Let's avoid using unnecessary ! to avoid crashes, even in tests.
Suggested change
| let mappedUrlItem = queryItems!.first(where: { $0 == .customItem })! | |
| self.customParameters = [mappedUrlItem] | |
| let mappedUrlItem = queryItems?.first(where: { $0 == .customItem }) | |
| self.customParameters = mappedUrlItem.map { [$0] } ?? [] |
| static let customItem: URLQueryItem = .init(name: "foo", value: "bar") | ||
| } | ||
|
|
||
| fileprivate final class CustomRouteOptions: NavigationRouteOptions { |
There was a problem hiding this comment.
There is already a class CustomRouteOptions in the TestHelper. Is it possible to reuse it there somehow?
| } | ||
|
|
||
| func testRouteRefreshWithCustomDrivingTrafficProfile() { | ||
| simulateAndTestOnRoute(with: .custom, shouldRefresh: true) |
There was a problem hiding this comment.
could you please rename .custom to .customDrivingTraffic so it's clear we don't refresh any custom profile, only the custom driving-traffic?
| } | ||
|
|
||
| func testRouteRefreshWithWalkingProfile() { | ||
| simulateAndTestOnRoute(with: .walking, shouldRefresh: false) |
There was a problem hiding this comment.
Could you please also add a separate test for
simulateAndTestOnRoute(with: .automobile, shouldRefresh: false)
kried
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge request contains only integration tests.
Covers: