[Core] Route refresh integration test #4802
Conversation
ArtemStepuk
changed the title
| ] | ||
| ), | ||
| .testTarget( | ||
| name: "MapboxCoreNavigationIntegrationTests", |
There was a problem hiding this comment.
When added as a test target, these tests will be run as a part of required job, as a MapboxNavigation-Package step
There was a problem hiding this comment.
yes thank you, that was my intention. On our side we are mocking the network.
There was a problem hiding this comment.
discussed in chat - some tests, might be flaky, let's see on a couple of runs how it acts.
| let mappedUrlItem = queryItems!.first(where: { $0 == .customItem })! | ||
| self.customParameters = [mappedUrlItem] |
There was a problem hiding this comment.
Let's avoid using unnecessary ! to avoid crashes, even in tests.
| let mappedUrlItem = queryItems!.first(where: { $0 == .customItem })! | |
| self.customParameters = [mappedUrlItem] | |
| let mappedUrlItem = queryItems?.first(where: { $0 == .customItem }) | |
| self.customParameters = mappedUrlItem.map { [$0] } ?? [] |
| static let customItem: URLQueryItem = .init(name: "foo", value: "bar") | ||
| } | ||
|
|
||
| fileprivate final class CustomRouteOptions: NavigationRouteOptions { |
There was a problem hiding this comment.
There is already a class CustomRouteOptions in the TestHelper. Is it possible to reuse it there somehow?
| } | ||
|
|
||
| func testRouteRefreshWithCustomDrivingTrafficProfile() { | ||
| simulateAndTestOnRoute(with: .custom, shouldRefresh: true) |
There was a problem hiding this comment.
could you please rename .custom to .customDrivingTraffic so it's clear we don't refresh any custom profile, only the custom driving-traffic?
| } | ||
|
|
||
| func testRouteRefreshWithWalkingProfile() { | ||
| simulateAndTestOnRoute(with: .walking, shouldRefresh: false) |
There was a problem hiding this comment.
Could you please also add a separate test for
simulateAndTestOnRoute(with: .automobile, shouldRefresh: false)
2 participants
Description
Merge request contains only integration tests.
Covers: