CMakeLists.txt: protobuf is only needed for tests #110
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't check for protobuf if tests are disabled. As a side effect, this will avoid a build failure if clang-tidy and protobuf are found but tests are disabled Fix mapbox#109 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Contributor
Author
|
Do you have some comments on this PR? |
joto
added a commit
to joto/protozero
that referenced
this pull request
Dec 19, 2024
This is a relacement for the PR mapbox#110 by @ffontaine which has conflicts.
Collaborator
|
Superseeded by #121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't check for protobuf if tests are disabled.
As a side effect, this will avoid a build failure if clang-tidy and protobuf are found but tests are disabled
Fix #109
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com