-
Notifications
You must be signed in to change notification settings - Fork 81
Update some stuff #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some stuff #117
Conversation
* Now needs a minimum of C++14, because the Protobuf library used in tests uses Absl which needs C++14 * Some changes to CMake config to make writer_tests compile on macOS and Windows * Updated Github action CI workflow
|
Last time I looked I was the maintainer of this software. But Mapbox has locked down the repo and I can't merge my own changes any more. Anybody at Mapbox seeing this? Please either give me some rights so that I can merge stuff or approve the PR. |
springmeyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. And I presume that the protozero headers will still continue to work with C++11 if anyone needed (as these changes are only build system + catch related)?
|
@flippmoke @brunoabinader - can either of you add a review or are able to merge this? |
|
@joto sorry for the delay. Could you please fix the remaining build failure? |
|
@kkaefer The build failure was not introduced by anything I changed in the code but by me updating the Github action scripts so they run on new machines. So it is a good thing we are catching that error now while it is only showing up on Debian experimental. So this PR is only one step, at least we know better where we stand after this. I am trying to get this to a point where I can maybe fix that build failure but the issues is with the test framework which hasn't been updated in many years which the new clang version doesn't like for some reason. But to move forward I first need the CI to work. |
Maybe, but the fix looks trivial (add |
It is unclear what the problem is, but this should "fix" it.
7d5b3ec to
16e41ee
Compare
|
Usually I don't like to disable warnings, but in this case I guess there is no way around for the moment. Until I can maybe get a newer version of the tests to run that doesn't require this any more. Done now. |
|
Well, the original warning was |
See individual commits.