Skip to content

Fix/set style update bug #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cioddi merged 2 commits into from
Oct 16, 2025
Merged

Fix/set style update bug #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0efca9
remove deprecated nx option --all from docs
cioddi Oct 16, 2025
1095fe6
fix: prevent unnecessary setStyle updates in MapLibreMap component.
cioddi Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions MonorepoNX-cheatsheet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ nx run {package-name}:{task-name}
E.g. to start the dev environment of the react-maplibre project run:

```sh
nx run react-maplibre:dev
nx run react-maplibre:storybook
```

Alternatively, you can also use:
Expand All @@ -47,7 +47,13 @@ nx {task-name} {package-name}
To run all tasks in parallel, use:

```sh
nx run-many --target={task-name} --all
nx run-many -t {task-name}
```

E.g. to start all storybooks in dev mode run:

```sh
nx run-many -t storybook
```

## Add New Projects
Expand Down
16 changes: 9 additions & 7 deletions packages/react-maplibre/src/components/MapLibreMap/MapLibreMap.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ const MapLibreMap: MapLibreMapComponent = (props: MapLibreMapProps) => {

if (mapContainer.current) {
initializedRef.current = true;
if (props?.options?.style) {
currentStyle.current = JSON.stringify(props.options.style);
}
mapRef.current = new MapLibreGlWrapper({
mapOptions: {
style: '',
Expand Down Expand Up @@ -120,13 +123,12 @@ const MapLibreMap: MapLibreMapComponent = (props: MapLibreMapProps) => {
}, [props.options, props.mapId]);

useEffect(() => {
if (
mapRef.current?.map &&
props?.options?.style &&
currentStyle.current !== props.options.style
) {
currentStyle.current = props.options.style;
mapRef.current.map.setStyle(props.options.style);
if (mapRef.current?.map && props?.options?.style) {
const newStyleString = JSON.stringify(props.options.style);
if (currentStyle.current !== newStyleString) {
currentStyle.current = newStyleString;
mapRef.current.map.setStyle(props.options.style);
}
}
}, [props?.options?.style]);

Expand Down
Loading