Skip to content

Conversation

@bradbrowne
Copy link

No description provided.

fxprunayre and others added 30 commits February 7, 2025 12:31
* Metadata citation improvements:

- BibTex: change data entry type to misc (data seems not valid: https://en.wikipedia.org/wiki/BibTeX\#Entry_types).
- RIS: add support for PY (publication year), DA (publication date) LA (language) fields.

* Metadata citation improvements: add option to save the citation to a file
* Restore metadata file store multiple files upload

* Restore metadata file store multiple files upload - remove duplicated check

* Restore metadata file store multiple files upload - initialize default value for singleUpload (overridable)
…ile (#8650)

* Update Transifex Dutch translations

* Added Dutch translations, improved a few original ones

* Update web/src/main/webapp/WEB-INF/classes/org/fao/geonet/api/Messages_dut.properties

---------

Co-authored-by: Sander Schaminee <[email protected]>
… store (#8639)

* Set the pasteZone for the fileupload directive

* Set the pasteZone for the fileupload directive to null
Added translations of analog elements from the iso19139 metadata schema.
Ubuntu 20.04 will become unsupported on 2025-04. Update the images used
in the Github Actions runners to one supported.

actions/runner-images#11101
* Update workflow status API to check if user can view record (and is an editor) instead or checking owner

* Change message to multilingual

* remove unused messages

* Update check to follow "minimum user profile allowed to view metadata history" logic

* Add missing messages

* Fix minimum profile not enforced

* Fix cannot get status when user cannot edit

* Move logic to reusable methods

* Fix french messages

* Update messages to use translated profile name from json

* Fix record not found not handled correctly

* Handle record not found for getWorkflowStatusByType
* Set related children's thumbnail to default 4

* Set children thumbnail to 20 for record view page
* Search result record abstract parsing improvement

* Update web-ui/src/main/resources/catalog/components/search/resultsview/ResultsviewDirective.js

Co-authored-by: Jose García <[email protected]>

* format pretty syntax, add double column binding

---------

Co-authored-by: Jose García <[email protected]>
- added xslt helper function to replace placeholders
- made sure shared strings can be used for the schematron localisation (schematron-shared.xml)
- fix in iso_svrl_for_xslt2.xsl to make sure $loc is also used when wrapped in a function
* Update translations and typo in one entry-code in ISO19139 Portuguese's codelists.xml

* Change encoding of ISO19139 Portuguese's codelists.xml from ISO-8859-1 to UTF-8 just like other languages

* Add function alias to codelist portuguese as to appear in add online resources
* added statuslabel next to the title in the formatter view (similar to Angular view)
* added check on div vs full html render
* feat(geonetwork/web): Add datahub integration.

* module and settings params

* documentation changes

* code review feedback

* add plugin to nav tree

* remove todo

* index static and normalize path (security)

* sonar rule

* better ignore the satahub path

* better path ignoring datahub plugin

* more complete documentation for datahub-integration

---------

Co-authored-by: Olivia <[email protected]>
* init toml configuration with TOML syntax coloration + init config

* datahub activated if plugin present - init

* correction of wrong id

* Read default config from resources instead of depending on SQL migration

* better doc

* better Sources admin UI for Datahub

* doc improvement

* rewrite base path in datahub

* Add datahub plugin in build process

---------

Co-authored-by: Olivia <[email protected]>
* Coordinated vulnerability disclosure 

Update security policy for Coordinated vulnerability disclosure.

* Update SECURITY.md

Co-authored-by: joachimnielandt <[email protected]>

* Update SECURITY.md

Co-authored-by: joachimnielandt <[email protected]>

* Update SECURITY.md

Co-authored-by: joachimnielandt <[email protected]>

---------

Co-authored-by: Jose García <[email protected]>
Co-authored-by: joachimnielandt <[email protected]>
tylerjmchugh and others added 30 commits October 22, 2025 13:26
* Add new settings for default options

* Implement options checkboxes on metadata creation page
* Fix query parameter name

* Clarify comments in BaseMetadataUtils.java

* Clarify comments in LocalizedEmailComponent.java
have to use ng-attr-href so to allow expression evalution in angular template for xlink:href.
if 'link' test for '../api/logos', have to href '../api/logos', not '../../images/harvesting'.
* [FP] Restrict username / group name characters (#5505)
* Improve username and group name patterns for valid characters:
- Group name may only contain alphanumeric characters and hyphens (not consecutive). Cannot begin or end with an hyphen.
- Username may only contain alphanumeric characters and hyphens, dots or colons or at-arrow (not consecutive). Cannot begin or end with an hyphen, colon or at-arrow.
- Max length of group name is 32.
- Max length of username is 255.

---------

Co-authored-by: Juan Luis Rodríguez <[email protected]>
* Allow editors to index their records
* Update documentation about privileges

---------

Co-authored-by: Juan Luis Rodríguez <[email protected]>
… to v4410 migration script. (#9079)

* Move system/metadata/edit/supportedFileMimetypes setting to from v444 to v4410 migration script.
Fixes changes from PR #7710.
* Also fixed other sql statement.
Add missing `scope="prototype"` to bean `geonetwork40` that was causing problems
related to always returning the same bean instance instead of a new one.
* Update uuid property on resource duplication

* Remove tests which were not being called

* Update javadoc
Introduces support for an API key header parameter in Harvesters. In the specific it adds complete support in Simple URL Harvester and CSW Harvester. Is it possible to add both the API Key value and the header parameter to use (default Authorization). The header is sent when API Key field is indicated.
Changed some of the conversion tool for xml to json and vice versa so that they support json arrays 
and other json nodes. Also fixed issue with indexer not being triggered after resources are uploaded.
* Support harvester log in subdirectory

* Add tests

* Fix test

* Fallback to base file name

* Fix unnessary change
* Add groupType property to Group

* Prevent importing or creating records on non-workspace groups

* Prevent changing groupType from workspace to non-workspace for groups that own records and prevent changing a non system group to a system group if it already has privileges assigned

* Fix restricted groups can have permissions set in batch privileges ui

* Prevent changing the owner group to a non-workspace group in the editor

* Update TransferApi to prevent transferring ownership to a non-workspace group

* Improve exception messages

* Fix users in group label is always shown

* Prevent setting profiles other than registered user for system groups

* Prevent setting privileges for system groups

* Disable minimumProfileForPrivileges when group type is system

* Add error modals for transfer ownership

* Add SQL statements for new column in groups table

* Update manual

* Update documentation

* Fix minimumProfileForPrivileges is not reset

---------

Co-authored-by: Jody Garnett <[email protected]>
Add configuration filter options for categories, metadata standard name, and group owners in 
GeoNetwork 4.x harvester.
* add test

* remove 'dead' code

* protocol and name for self

* add items link

* use id as onLine name, use 'STAC Collection' as protocol for 'self'
* Extract "get or create group" logic to new BaseUserUtils class

* Update oidc to handle system groups in role names

* Add / fix tests

* Show system privileges in the users ui

* Change onlyIncludeWorkspaces flag to an optional list of group types

* Move default group type to the domain

* Fix ShibbolethUserUtilsTest

* Whitespace

* Resolve comments
Currently, when deploying GeoNetwork 5 with GeoNetwork 4 sign in operation are managed by version 5. This adds the possibility to sign in from GeoNetwork 4 directly.

Configuration steps for GN4 are:

* start with `-Dgeonetwork.security.type=gn5`
* In `config-security.properties`, configure the URLs for login and logout to point to GN5 (this could maybe be avoided with X-Forwarded headers?):

```properties
logout.success.url=http://localhost:7979/geonetwork/srv/eng/catalog.search
loginForm=http://localhost:7979/geonetwork/srv/eng/catalog.signin
loginErrorForm=http://localhost:7979/geonetwork/srv/eng/catalog.signin?failure=true
```

* In UI configuration, enable the authentication and set the signin/signout URLs to use the GN5 URLs:

```json
     "authentication": {
          "enabled": true,
          "signinUrl": "../../{{node}}/{{lang}}/catalog.signin",
          "signinAPI": "../../api/user/signin",
          "signoutUrl": "../../api/user/signout"
```
Currently when multilingual emails contain french they are failing to send. In #8820 the index
field placeholders ({{index:resourceTitleObject}}) were updated so they were escaped using 
two single quotes instead of a one single quote. This confuses MessageFormat.format into 
thinking the index placeholder {{index:resourceTitleObject}} is a numeric placeholder 
intended for the MessageFormat.format call.

This commit aims to fix this issue by reverting the fields to consistently use one single 
quote instead of two.
* add test

* full view: onlineresource linkage with multilingual support & use url when no name
… changed (#9052)

Not a usual case, but some metadata schemas like Dutch datasets / services have different versions
of the schemas and users can upgrade to the newer versions the existing metadata.

The harvesters code when updating a metadata, was not checking if the schema version changed, 
only updating the XML.

This pull request updates the following harvesters to deal with this use case:
* CSW
* Database
* GeoNetwork
* OAI-PMH
* SFTP
* WebDav
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.