Fix Erase Terrain button not activating Terrain brush#4347
Open
JustJ01 wants to merge 1 commit intomapeditor:masterfrom
Open
Fix Erase Terrain button not activating Terrain brush#4347JustJ01 wants to merge 1 commit intomapeditor:masterfrom
JustJ01 wants to merge 1 commit intomapeditor:masterfrom
Conversation
Member
|
I've just removed that button in #4320 (not merged yet, but it's mostly just waiting for a slight name change). However, I noticed this issue is not fixed yet. Maybe you could have a look at rebasing your change onto the |
Author
|
Thanks @bjorn for the review, I will look at the codebase of that branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4177
Description:
A bug was reported where clicking Erase Terrain in the Terrain Sets dock cleared the current terrain selection but did not switch the active tool to the Terrain Brush. This left users painting with whatever tool was previously selected (Stamp Brush) and broke the expected workflow.
Before:
In the video , you can see when
Erase Terrainbutton was pressed , the current tool remainedStamp Brushinstead of swtiching toTerrain Brush.Screen.Recording.2026-02-21.155735.mp4
After:
After the change, clicking
Erase Terrainalways activates theTerrain Brush, restoring the intended behaviour.Screen.Recording.2026-02-21.160846.mp4