Update JasperReports to version 7 #3632
Conversation
JapserReport file format has changed and subreport now also has <parameter> tags, instead of <subreportParameter> and that confuses the parser. For example, see change for test/resources/examples/oereb/pdfextract.jrxml
From the artifact of the previous workflow run
lanseg
changed the title
sbrunner
left a comment
sbrunner
left a comment
There was a problem hiding this comment.
I'm surprised that there are so many (7) new dependencies, otherwise that looks good :-)
sbrunner
changed the title
Many of those modules are not needed to compile the code, but some of them are loaded indirectly by Class.forName or other dependencies. |
|
@sbrunner I label this PR as an enhancement, as the changes are not backward compatible. The reports will need to be migrated to be compatible with Jasper report 7. Agreed ? |
| for (int i = 0; i < parameters.getLength(); i++) { | ||
| final Element param = (Element) parameters.item(i); | ||
| final String name = param.getAttribute("name"); | ||
| if (!param.getParentNode().getNodeName().equals("jasperReport")) { |
There was a problem hiding this comment.
To avoid unnecessary NPE, Please revert the .equals parameters
| <rightPen lineWidth="0.0" lineStyle="Solid" lineColor="#000000"/> | ||
| </box> | ||
| <conditionalStyle> | ||
| <conditionalStyle mode="Opaque" backcolor="#F2F2F2"> |
| <band/> | ||
| </summary> | ||
| <pageFooter/> | ||
| <summary/> |
| 'joda-time:joda-time:2.13.1', | ||
| 'com.itextpdf:itextpdf:5.5.13.4', | ||
| 'joda-time:joda-time:2.14.0', | ||
| 'net.sf.jasperreports:jasperreports:7.0.2', |
There was a problem hiding this comment.
Please check and confirm all these jasper reports libs are opensource. Write in the description a brief explanation of the licensing changes between 6.21.x and 7.0.x (do not hesitate to add links to jasper report documentation)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Cancellation as soon as possible of a generation that will fail * Cancellation as soon as possible of a generation that will fail
* Yaml reader is not thread safe * Yaml reader is not thread safe
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This is done by the automated script named upgrade-ci-2025
From the artifact of the previous workflow run
…isplays the position of the pages (#3618) * Feature : paging add an option to add an overview layer to the main map that displays the position of the pages on the main map
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…for all layers (#3623) * Add forceFailOnError configuration parameter to set failOnError on all layers
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This is done by the automated script named upgrade-ci-2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
| 'joda-time:joda-time:2.14.0', | ||
| 'org.jfree:jcommon:1.0.24', | ||
| 'org.apache.groovy:groovy-all:4.0.26', | ||
| 'xalan:serializer:2.7.3', |
There was a problem hiding this comment.
Why get them out of the jasper section?
It's no more working?
There was a problem hiding this comment.
It worked, but it would be better if it contains only jasper libraries
There was a problem hiding this comment.
Personally, I like to have all the dependency related to jasper in the same section @sebr72 what do you think?
|
This PR was resolved by: |
See JIRA issue: GSMFP-45.
Breaking changes
JRXML file format. Due to changes in the JasperReports itself, older jrxml files has become incompatible with the newer version of the library and all the examples had to be updated with the JasperReports studio. For details please see:
Explicit dependencies
// TODO: add note about the extra dependencies