Skip to content

CI: install pysocks when building binaries #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ptpt merged 1 commit into from
Oct 13, 2022
Merged

CI: install pysocks when building binaries #567

ptpt merged 1 commit into from
Oct 13, 2022

Conversation

@ptpt
Copy link
Member

@ptpt ptpt commented Oct 12, 2022 •
edited
Loading

Fixes #566

@JakeSmarter
Copy link
Contributor

JakeSmarter commented Oct 12, 2022

Build lacks bump to 0.9.5a.

I am going to test this build asap…

@JakeSmarter
Copy link
Contributor

JakeSmarter commented Oct 13, 2022

The SOCKS proxy part works as expected again. Thank you! 👍

@JakeSmarter JakeSmarter mentioned this pull request Oct 13, 2022
Closed
@ptpt ptpt merged commit 7ca8aa2 into main Oct 13, 2022
@ptpt ptpt deleted the ci-build-binary-with-pysocks branch October 13, 2022 19:00
@JakeSmarter
Copy link
Contributor

JakeSmarter commented Sep 10, 2024 •
edited
Loading

Please add pysocks to requirements.txt on the main branch. Otherwise, SOCKS support does not work if you install mapillary_tools via pip3.

@ptpt
Copy link
Member Author

ptpt commented Nov 23, 2024

@JakeSmarter Adding it in #688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Regression] SOCKS/proxy support broken

4 participants

@ptpt @JakeSmarter @facebook-github-bot