Remove resampling validation logic for raster layers#7224
Merged
HarelM merged 3 commits intomaplibre:mainfrom Mar 8, 2026
Merged
Remove resampling validation logic for raster layers#7224HarelM merged 3 commits intomaplibre:mainfrom
resampling validation logic for raster layers#7224HarelM merged 3 commits intomaplibre:mainfrom
Conversation
Style spec v24.7.0 now validates redundant properties
Collaborator
|
Thanks!! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7224 +/- ##
==========================================
- Coverage 92.71% 92.71% -0.01%
==========================================
Files 289 289
Lines 24077 24074 -3
Branches 5114 5112 -2
==========================================
- Hits 22323 22320 -3
Misses 1754 1754 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
HarelM
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
resamplingandraster-resamplingpaint propertiesStyle spec v24.7.0 now validates that raster layers do not specify both
resamplingandraster-resamplingpaint properties. We can remove the validation I originally added in #7194.Launch Checklist
No CHANGELOG entry because I consider it an addendum to #7194 which was merged but not yet released.