Skip to content

Remove resampling validation logic for raster layers#7224

Merged
HarelM merged 3 commits intomaplibre:mainfrom
larsmaxfield:cleanup/raster-resampling
Mar 8, 2026
Merged

Remove resampling validation logic for raster layers#7224
HarelM merged 3 commits intomaplibre:mainfrom
larsmaxfield:cleanup/raster-resampling

Conversation

@larsmaxfield
Copy link
Contributor

@larsmaxfield larsmaxfield commented Mar 8, 2026

Changes:

  • Remove raster layer validation logic for redundant resampling and raster-resampling paint properties
  • Update maplibre-style-spec version to v5.24.7

Style spec v24.7.0 now validates that raster layers do not specify both resampling and raster-resampling paint properties. We can remove the validation I originally added in #7194.

Launch Checklist

  • Briefly describe the changes in this PR.

No CHANGELOG entry because I consider it an addendum to #7194 which was merged but not yet released.

Style spec v24.7.0 now validates redundant properties
@HarelM
Copy link
Collaborator

HarelM commented Mar 8, 2026

Thanks!!
Can you update the spec package version as part of this PR?

@codecov
Copy link

codecov bot commented Mar 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.71%. Comparing base (8613002) to head (8526ca7).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7224      +/-   ##
==========================================
- Coverage   92.71%   92.71%   -0.01%     
==========================================
  Files         289      289              
  Lines       24077    24074       -3     
  Branches     5114     5112       -2     
==========================================
- Hits        22323    22320       -3     
  Misses       1754     1754              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​maplibre/​maplibre-gl-style-spec@​24.6.0 ⏵ 24.7.093 +110099 +197 +370

View full report

@HarelM HarelM enabled auto-merge (squash) March 8, 2026 13:06
@HarelM HarelM merged commit 568dccd into maplibre:main Mar 8, 2026
24 checks passed
@larsmaxfield larsmaxfield deleted the cleanup/raster-resampling branch March 8, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants