feat: restrict sideEffects to CSS files in package.json#7258
Open
CommanderStorm wants to merge 1 commit intomaplibre:mainfrom
Open
feat: restrict sideEffects to CSS files in package.json#7258CommanderStorm wants to merge 1 commit intomaplibre:mainfrom
sideEffects to CSS files in package.json#7258CommanderStorm wants to merge 1 commit intomaplibre:mainfrom
Conversation
sideEffects to CSS files in package.json
sideEffects to CSS files in package.jsonsideEffects to CSS files in package.json
Collaborator
|
I need to read about what this means, never saw it before. Thanks for taking the time to open this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7258 +/- ##
=======================================
Coverage 92.71% 92.71%
=======================================
Files 289 289
Lines 24074 24074
Branches 5112 5112
=======================================
Hits 22321 22321
Misses 1753 1753 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Launch Checklist
We are missing the
sideEffectsflag in our package-json, which means that bundlers currently have to be extra cautios when optimising us.The
*.cssis something that we can likely also remove, but this is a bit unclear to me if they are actually side effect freeThis is uneesseary and we can instead just let them optimise us.
I am putting this into v6 since it is fairly hard to predict if this is actually safe.
According to our tests it is, and we are not using side-effect ridden things in the main apis that I looked at (plus in the many more minor APIs that I let claude audit).