Conversation
Reason: previously the wrong callback was used
Reason: otherwise the static_assertion checks are wrong
… to have a more fluent usage
Reason: the MapObserver Instance got deleted after the MapRenderer_new_with_observer call, because the variable which has the pointer to the MapObserver gets deleted and then also the references pointing on it are invalid
Reason: unintentionally added. It does nothing
Reason: Otherwise we have a livetime problem if the function is not static. For Closures move must be used to capture all variables by value!
Reason: because it is important to set it
Reason: Using opaque objects is better so no unsafe conversion is required
Reason: less error prone and less unsafe code
0539d03 to
6993e5c
Compare
0d2e4ae to
6b267f7
Compare
for more information, see https://pre-commit.ci
|
hi @Murmele thx for all the hard work on this!!! Please join us in https://slack.openstreetmap.us/ on slack - this way you can chat directly with all of us and we can collaborate better. Let me know if you need any help. |
|
@mwilsnd for some reason I cannot add you to the reviewers, but your feedback would be great! |
Thanks for the invitation! Is there a channel related to maplibre or just the general? |
|
|
| const size_t pixelCount = mSize.width * mSize.height; | ||
| constexpr size_t bytes_per_pixel = 4; // rgba | ||
| // TODO: why *2? | ||
| return sizeof(uint32_t) * 2 + pixelCount * bytes_per_pixel; |
There was a problem hiding this comment.
Looking at how the allocation size is determined in native here, this should just be 4 * width * height. Are you seeing a bounds check or alignment failure unless you allocate extra space?
If you try to resize the frontend two or more times before calling |
Yes maybe this is missing: maplibre/maplibre-native#4030 |
|
I will check it out next weeks to get it build again |
|
thanks!!! I have been using github's copilot quiet successfully - the only problem with it is that it doesn't work across forks :( I'll see if i can just create an extra issue and assign it - maybe it will self-heal |
|
I created #129 - will see what copilot does :) |
|
horray, this PR passes once again. What the status of it? I would looooove to have this as part of mln-rs :) |
The PR passes, but in my testapplication it does not compile anymore because of missing libraries in the almagan (was it the mln texture?). I hope I get it this week up :) |
for more information, see https://pre-commit.ci
This PR is far away from being finished, but maybe someone can have a look on it and provide feedback.
Implement continuous mode with map and renderer observer.
Not working
setSize still crashesDoesn't crash, but resize does not work yet (Fix Vulkan headless backend resize maplibre-native#4030)renderer observer callback gets never calledNot required anymore, because only MapObserver is usedTesting
Currently I am testing it in my project with Slint: https://gitlab.com/Murmele/slintmaplibretest
Launch Checklist
CHANGELOG.mdunder the## mainsection.