chore(ci): modify test snapshots to fix CI failures#130
Merged
Conversation
Co-authored-by: nyurik <1641515+nyurik@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI to ensure tests pass
Update test snapshots to fix CI failures
Feb 17, 2026
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nyurik
approved these changes
Feb 17, 2026
Member
nyurik
left a comment
There was a problem hiding this comment.
we shouldn't use pngs as snapshots - too flaky. Perhaps one day there could be a better way to do this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI failing on snapshot mismatches in pool tests. Rendering output from maplibre-native changed slightly since snapshots were last updated.
Changes
Updated 5 snapshot PNG files:
pool__large_coordinates_handled.snap.pngpool__sequential_errors_dont_break_pool.snap.pngpool__style_switching_.snap.pngpool__style_switching_-2.snap.pngpool__style_switching_-3.snap.pngAll affected tests (
large_coordinates_handled,sequential_errors_dont_break_pool,style_switching_) now pass withjust ci-test vulkan.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
demotiles.maplibre.org/home/REDACTED/work/maplibre-native-rs/maplibre-native-rs/target/debug/deps/render-948d5f51740b5f1a /home/REDACTED/work/maplibre-native-rs/maplibre-native-rs/target/debug/deps/render-948d5f51740b5f1a cxxbridge/includ-r known-linux-gnu/.workflow_runs[] | "\(.id) \(.name) \(.conclusion // "running") \(.head_branch) \(.created_at)" known-linux-gnu/lib/rustlib/x86_1 know�� known-linux-gnu/lib/rustlib/x86_-C a-70ec0a6e66a4a2e2.cargo_insta.6ba5cc3bed9c5748-cgu.00.rcgu.o a-70ec0a6e66a4a2e2.cargo_insta.6ba5cc3bed9c5748-cgu.01.rcgu.o a-70ec0a6e66a4a2/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/cargo a-70ec0a6e66a4a2metadata a-70ec0a6e66a4a2--format-version=1 a-70ec0a6e66a4a2--no-deps a-70�� a-70ec0a6e66a4a2e2.cargo_insta.6ba5cc3bed9c5748-cgu.07.rcgu.o a-70ec0a6e66a4a2e2.cargo_insta.6ba5cc3bed9c5748-cgu.08.rcgu.o a-70ec0a6e66a4a2e2.cargo_insta.6ba5cc3bed9c5748-cgu.09.rcgu.o a-70ec0a6e66a4a2sh a-70ec0a6e66a4a2-cu a-70ec0a6e66a4a2echo "PWD $(pwd)" a-70ec0a6e66a4a2e2.cargo_insta.6ba5cc3bed9c5748-cgu.13.rcgu.o(dns block)/home/REDACTED/work/maplibre-native-rs/maplibre-native-rs/target/debug/deps/render-d3ac9e43cf38b0cf /home/REDACTED/work/maplibre-native-rs/maplibre-native-rs/target/debug/deps/render-d3ac9e43cf38b0cf bre_native-1bfa75c11f96a3ec/build_script_build-1bfa75c11f96a3ec.1t7qbm3royus6ct17gvb�� bre_native-1bfa75c11f96a3ec/build_script_build-1bfa75c11f96a3ec.1umpspre6uyboemlxn00n916f.01mtorr.rcgu.o bre_native-1bfa75c11f96a3ec/build_script_build-1bfa75c11f96a3ec.23cmrud6gfeepwcvmvh0lpq3o.01mtorr.rcgu.o bre_native-1bfa75c11f96a3ec/build_script_build-1bfa75c11f96a3ec.2imdp3bly9jphzu13qwqie9ui.01mtorr.rcgu.o bre_native-1bfa75c11f96a3ec/build_script_build-1bfa75c11f96a3ec.2q4p9l2pv5v4xjdwbna68f9q0.01mtor/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/rustc bre_native-1bfa75c11f96a3ec/build_script_build-1bfa75c11f96a3ec.340l1uj51qvgjr4jzp3w9ciqa.01mtor--crate-name bre_native-1bfa75c11f96a3ec/build_script_build-1bfa75c11f96a3ec.370pzzpdtuzqgg6g184702uso.01mtorclap bre_native-1bfa75c11f96a3ec/build_script_build-1bfa75c11f96a3ec.3bjk9zq1q34yinap1u96xmprw.01mtor--edition=2021 bre_native-1bfa75c11f96a3ec/build_script_build-1bfa75c11f96a3ec.3oqog9p7d2p2vyxe044o�� bre_native-1bfa75c11f96a3ec/build_script_build-1bfa75c11f96a3ec.43dn463epgglwv8cn7gudfxck.01mtor--error-format=json bre_native-1bfa75c11f96a3ec/build_script_build-1bfa75c11f96a3ec.4qmku1y0b5xcboeugffjealsk.01mtor--json=diagnostic-rendered-ansi,artifacts,future-incompat bre_�� bre_native-c4046fc8c6bcf90c/out/cxxbridge/include bre_native-1bfa75c11f96a3ec/build_script_build-1bfa75c11f96a3ec.63p4om76l50ta8qerjsxbn79v.01mtorcq bre_native-c4046fc8c6bcf90c/out/cxxbridge/crate u.o u.o u.o bre_native-c4046fc8c6bcf90c/out/maplibre-native/headers/vendor/maplibre-native-base/include(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.