fix: apply zoomRate to delta instead of absolute zoom in quick zoom gesture#4101
Open
UlysselaGlisse wants to merge 1 commit intomaplibre:mainfrom
Open
fix: apply zoomRate to delta instead of absolute zoom in quick zoom gesture#4101UlysselaGlisse wants to merge 1 commit intomaplibre:mainfrom
UlysselaGlisse wants to merge 1 commit intomaplibre:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect
zoomRateapplication during quick zoom gesture (double-tap + drag).Problem
When
uiSettings.zoomRate ≠ 1.0, quick zoom causes an immediate jump to an unexpected zoom level becausezoomRatewas being multiplied against the absolute zoom level instead of the zoom delta.Example: At zoom level 10 with
zoomRate = 2.0, initiating quick zoom would jump directly to level 20.Solution
Apply
zoomRateto the normalized delta change (like pinch-to-zoom already does) rather than to the final target zoom value.Testing
I haven't automated testing, so i just test this solution manually.
Other
This is my first contribution to this project - please let me know if any changes are needed.