Merged
Conversation
Contributor
|
LETS GOOOOOO |
michaelkirk
reviewed
Aug 6, 2024
michaelkirk
left a comment
There was a problem hiding this comment.
Cool. Just a drive by review, my first peep at maplibre-rs code.
Collaborator
Author
others:
|
2c4d481 to
5085420
Compare
Contributor
|
When will this be merged? |
Collaborator
Author
|
On time for Christmas 🤞 |
Collaborator
Author
|
@michael-markl pls review |
bb2e07b to
3fbe3c1
Compare
Member
|
This PR appear to be working as expected, is anything holding it from review? |
birkskyum
previously approved these changes
May 15, 2025
c290442 to
7b26e40
Compare
Collaborator
Author
|
@birkskyum appreciate you taking over here :) i think it makes a lot sense though to create a separate PR here. I don't know what my local state is and force pushing on a shared branch is problematic 😅 |
…nfig - Upgrade stable toolchain 1.82→1.85 (Cargo 1.85 stabilized edition2024, required by http-cache-semantics v2.1.1, moxcms v0.7.11, home v0.5.12) - Upgrade nightly toolchain to nightly-2025-03-01 (also needs edition2024) - Fix stable-targets/nightly-targets: use `rustup target add --toolchain` instead of `rustup toolchain install --target` (new rustup rejects multiple space-separated targets after a single --target flag) - Fix demo-windows: use bash --noprofile --norc so just inherits the parent PATH (including cargo bin) instead of resetting it via msys2's /etc/profile - Remove mdbook `multilingual` field removed in newer mdbook versions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Screen.Recording.2026-02-19.at.00.33.09.movSeems like a good addition, where the additional TODOs can come in increments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
video.webm
TODO:
Q:
The basic implmenetation for SDFs is based on https://github.com/stadiamaps/maps-rs (licensed as MIT OR APACHE)