Restore classic theme variant for Zensical migration#1529
Restore classic theme variant for Zensical migration#1529CommanderStorm merged 1 commit intomainfrom
Conversation
The Zensical migration in #1394 defaulted to the modern theme variant, which dropped the sidebar navigation and MapLibre branding. Adding variant: classic restores the Material for MkDocs look and feel.
|
Size Change: 0 B Total Size: 137 kB ℹ️ View Unchanged
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1529 +/- ##
=======================================
Coverage 93.78% 93.78%
=======================================
Files 112 112
Lines 4668 4668
Branches 1571 1571
=======================================
Hits 4378 4378
Misses 290 290 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I filed: zensical/ui#80 |
CommanderStorm
left a comment
There was a problem hiding this comment.
I really like the new design and am fairly sad to revert to the old design.
I guess, we can revert until I can bug one of my coworkers to lend me their mac or something.
The viewports could have a sidebar for be a bit wider, but not actually for that much longer.
|
The is being caused by the tablet CSS is coming through on desktop screens. Updated the issue I filed with Zensical. The issue is resolved on my local machine, but not when the PR is merged. Ok to revert until we have a proper workaround or fix. |

Zensical migration dropped the sidebar navigation and MapLibre branding when viewed in Safari. Adding variant: classic restores the Material for MkDocs look and feel.
No console log errors in Safari.
Issue not reproduced on Chrome or Firefox.
I suspect this is an upstream issue with Zensical... investigating and will report back, in the meantime, any objection to reverting to the "classic" theme?
EDIT: I filed zensical/ui#80
Testing
Fix works locally
Launch Checklist
CHANGELOG.mdunder the## mainsection.