Skip to content

Restore classic theme variant for Zensical migration#1529

Merged
CommanderStorm merged 1 commit intomainfrom
fix/docs-zensical-classic-theme
Mar 4, 2026
Merged

Restore classic theme variant for Zensical migration#1529
CommanderStorm merged 1 commit intomainfrom
fix/docs-zensical-classic-theme

Conversation

@mizmay
Copy link
Contributor

@mizmay mizmay commented Mar 4, 2026

Zensical migration dropped the sidebar navigation and MapLibre branding when viewed in Safari. Adding variant: classic restores the Material for MkDocs look and feel.

No console log errors in Safari.

Issue not reproduced on Chrome or Firefox.

I suspect this is an upstream issue with Zensical... investigating and will report back, in the meantime, any objection to reverting to the "classic" theme?

EDIT: I filed zensical/ui#80

Before After
Screenshot 2026-03-04 at 2 17 38 PM Screenshot 2026-03-04 at 2 17 58 PM

Testing

Fix works locally

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

The Zensical migration in #1394 defaulted to the  modern theme variant, which dropped the sidebar navigation and MapLibre branding. Adding variant: classic restores the Material for MkDocs look and feel.
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Size Change: 0 B

Total Size: 137 kB

ℹ️ View Unchanged
Filename Size
dist/index.cjs 68.8 kB
dist/index.mjs 67.7 kB

compressed-size-action

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.78%. Comparing base (2d72bca) to head (981e1a9).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1529   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files         112      112           
  Lines        4668     4668           
  Branches     1571     1571           
=======================================
  Hits         4378     4378           
  Misses        290      290           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mizmay
Copy link
Contributor Author

mizmay commented Mar 4, 2026

I filed: zensical/ui#80

@CommanderStorm
Copy link
Member

CommanderStorm commented Mar 4, 2026

Are you maybe on mobile/tablet sized viewports, right? (the screenshots are not that wide)
If that is the case, you would need to click on the hamburger icon at the top to view this menu, at least on chrome.

image

Or is the issue that this menu does not show up?

Copy link
Member

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the new design and am fairly sad to revert to the old design.

I guess, we can revert until I can bug one of my coworkers to lend me their mac or something.
The viewports could have a sidebar for be a bit wider, but not actually for that much longer.

@CommanderStorm CommanderStorm merged commit 906fcc5 into main Mar 4, 2026
8 checks passed
@CommanderStorm CommanderStorm deleted the fix/docs-zensical-classic-theme branch March 4, 2026 23:26
@mizmay
Copy link
Contributor Author

mizmay commented Mar 4, 2026

The is being caused by the tablet CSS is coming through on desktop screens. Updated the issue I filed with Zensical.

The issue is resolved on my local machine, but not when the PR is merged. Ok to revert until we have a proper workaround or fix.

@mizmay mizmay restored the fix/docs-zensical-classic-theme branch March 4, 2026 23:43
mizmay added a commit that referenced this pull request Mar 4, 2026
mizmay added a commit that referenced this pull request Mar 5, 2026
…on (#1529)" (#1530)

This reverts commit 906fcc5.

Co-authored-by: Stephanie May <3074691+mizmay@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants