Support SwiftSyntax v601 #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #if canImport(SwiftSyntax601) | ||
| // This provides compatibility for the new SwiftSyntax API, returning an empty result if the argument has | ||
| // been parsed as an expression. | ||
| private func generateStyleProperty(for attributes: AttributeSyntax, valueType: GenericArgumentSyntax.Argument, |
There was a problem hiding this comment.
This doesn't seem to be used anywhere; am I missing something?
There was a problem hiding this comment.
Yeah, it might not be straight forward, but this is what's going on:
- SwiftSyntax 601 introduces a new nested
GenericArgument.Argumenttype because the parser can now parse types and expressions (experimental). - So in 601,
GenericArgumentSyntax.argumentdoesn't give you aTypeSyntaxas before, but this new enum. - This code provides an override (conditional on SwiftSyntax601) to
generateStylePropertythat takes this newArgumenttype and unwraps it to send to the existinggenerateStylePropertyfunction. - This means you don't need any changes at the call site, but in 601 it is actually calling this override.
Does that make sense?
There was a problem hiding this comment.
Oh, wow 😅 Yeah, I think that makes sense. Thanks! I'll get the swiftformat stuff cleaned up and we can get this merged.
ianthetechie
approved these changes
Jun 23, 2025
|
Thanks for the merge. Excited for the faster compile times! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Motivation
SwiftSyntax 601.0.1 is the first version of the library that supports the new preview for prebuilts in SPM. This functionality dramatically improves build times (especially in release configuration) for macro libraries. Now that Mockable 0.4.0 supports SwiftSyntax v601, the path is cleared for this library.
Tasklist
Package.swiftto support SwiftSyntax up to and including v601.MapLibreSwiftUIin debug/release configurations and benchmark against SwiftSyntax 510.0.3 and 601.0.1.Outcome
MapLibreSwiftUIbuilds dramatically faster in both configurations. While it was hard to benchmark builds in Xcode accurately--sinceswift buildwill fail--I saw times drop from several minutes to archive down to just a matter of seconds. This is consistent with the results I saw onMockablewith release builds falling from ~140s down to 9s.Caution
MapLibreSwiftUIwon't build against SwiftSyntax 601.0.0 due to a missing marker module that was fixed in 601.0.1.