Skip to content

Update SSSOM Extended Prefix Map#568

Merged
matentzn merged 2 commits intomasterfrom
create-pull-request/patch
May 22, 2025
Merged

Update SSSOM Extended Prefix Map#568
matentzn merged 2 commits intomasterfrom
create-pull-request/patch

Conversation

@github-actions
Copy link
Contributor

This pull request updates sssom extended prefix map (epm). Make sure you run make tests manually.

Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fearing the pubmed ID with whitespace might cause issues, wanting @cthoyt feedback before proceeding

@github-actions github-actions bot force-pushed the create-pull-request/patch branch 2 times, most recently from 8a140ac to 20d99f6 Compare December 30, 2024 12:22
@github-actions github-actions bot force-pushed the create-pull-request/patch branch 2 times, most recently from f3e409f to a497556 Compare January 20, 2025 12:22
Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cthoyt can you check my comments to see if I am on the wrong track somewhere?

@github-actions github-actions bot force-pushed the create-pull-request/patch branch from a497556 to d7fc3fe Compare March 3, 2025 12:23
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from d7fc3fe to 96989b9 Compare March 10, 2025 12:24
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from 96989b9 to addd531 Compare March 24, 2025 12:25
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from addd531 to d5df59d Compare April 7, 2025 12:26
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from d5df59d to 47cabfc Compare April 21, 2025 12:25
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from 47cabfc to a3a7c1b Compare April 28, 2025 12:25
matentzn
matentzn previously approved these changes Apr 28, 2025
@matentzn matentzn closed this Apr 28, 2025
@matentzn matentzn reopened this Apr 28, 2025
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from a3a7c1b to 1ad00fe Compare May 5, 2025 12:26
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from ac2aa7f to 7099da0 Compare May 22, 2025 06:23
@cthoyt
Copy link
Member

cthoyt commented May 22, 2025

@matentzn I think this is passing now

sorry, CI doesn't run on GHA pushes

@cthoyt cthoyt enabled auto-merge (squash) May 22, 2025 06:25
@cthoyt cthoyt disabled auto-merge May 22, 2025 06:25
@matentzn matentzn closed this May 22, 2025
@matentzn matentzn reopened this May 22, 2025
@cthoyt
Copy link
Member

cthoyt commented May 22, 2025

@matentzn this is ready for final review / merge. Would be great to get a new sssom-py release after!

Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible work @cthoyt really a lot of massive improvements!

Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible work @cthoyt really a lot of massive improvements!

@matentzn matentzn merged commit 162258c into master May 22, 2025
8 checks passed
@matentzn matentzn deleted the create-pull-request/patch branch May 22, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants