Conversation
matentzn
reviewed
May 19, 2025
Collaborator
matentzn
left a comment
matentzn
left a comment
There was a problem hiding this comment.
Just a minor comment but this looks great! THANKS a ton and a million sorry for the delayed review!
matentzn
previously approved these changes
May 19, 2025
Member
Author
Member
Author
|
sorry @matentzn I need a re-review, since there was a test I hadn't noticed had failed; related to checking the validate function returned none, and now it returns something that we can actually check in more depth! |
matentzn
approved these changes
May 19, 2025
Collaborator
matentzn
left a comment
matentzn
left a comment
There was a problem hiding this comment.
Thanks for the test fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm currently trying to use
sssom.io.validate_pathto check that SSSOM files generated by SeMRA are valid, but it's very difficult to get access to the results of validation programmatically. There should be some logging output to stderr, but this isn't so helpful in a unit testing environment.This PR makes the validation functions return the reports generated by LinkML, so they can be returned and used downstream.
This PR also operationalizes the default validator list, meaning you don't have to import them or know what they are to get this function up and running.
Blocked by #580
Alternative to #387, but that PR uses custom results instead of returning the LinkML objects