-
Notifications
You must be signed in to change notification settings - Fork 13
Add method to infer minimum compatible SSSOM version. #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Add a new method to the MappingSetDataFrame class to automatically determine the minimum version of the SSSOM specification the set is compatible with -- that is, the earliest version that defines all the slots and all the enum values present in the set.
|
Fix wrong slot name when looking for "composed entity expression". Let Python compare version numbers as tuples of integers. Use `max(list)` instead of `sorted(list)[-1]`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just want to say a huge THANK YOU for these PRs.. Much appreciated.
I dont see any red flags, lgtm!
Marking as draft to prevent inadvertent premature merging. |
This PR adds a new method to the
MappingSetDataFrame
class to automatically determine the minimum version of the SSSOM specification the set is compatible with – that is, the earliest version that defines all the slots and all the enum values present in the set.This method could later be used to implement the behaviour recommended by the spec: automatically inserting the
sssom_version
slot when a set is written, if the set requires another version than 1.0. This could simply look like: