Use latest pre-release of the SSSOM schema.#625
Merged
gouttegd merged 2 commits intomapping-commons:masterfrom Oct 8, 2025
Merged
Use latest pre-release of the SSSOM schema.#625gouttegd merged 2 commits intomapping-commons:masterfrom
gouttegd merged 2 commits intomapping-commons:masterfrom
Conversation
Update the sssom_schema dependency to use the latest 1.1.0 pre-release, so that we can start using the new slots and enum values in the upcoming version of the specification and ensure that SSSOM-Py is ready to work with them.
The `inject_metadata_into_df` function (whose entire purpose is very dubious but that is another matter) needs a list of the slots available in the mapping class. It gets that list by doing its own loading of the SSSOM schema. It does so without specifying any encoding for the schema file, and apparently the default YAML parser, when not provided with an explicit encoding on Windows, assumes the encoding is CP-1252. This results in a failure to load the schema if it happens to contain UTF-8-encoded non-ASCII characters (which in version 1.1.0a2 it does, because we are no longer in the 1980s). This commit updates the `inject_metadata_into_df` function so that it reuses the SSSOMSchemaView class, which is precisely intended to give access to the contents of the schema.
matentzn
approved these changes
Oct 8, 2025
Collaborator
matentzn
left a comment
matentzn
left a comment
There was a problem hiding this comment.
Very awesome, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
sssom_schemadependency to use the latest 1.1.0 pre-release, so that we can start using the new slots and enum values in the upcoming version of the specification and ensure that SSSOM-Py is ready to work with them.