Move definition of propagation/condensation outside of SSSOM/TSV. #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propagation and condensation of "propagatable" slots is currently defined in the specification for the SSSOM/TSV format. This is not appropriate as those operations are completely independent of the serialisation format -- propagation and condensation are performed identically regardless of whether a mapping set is read/written from/to a SSSOM/TSV file, a SSSOM/JSON file, or a RDF file. So here, we move the definition of those operations to the general introduction (serialisation-independent) to the SSSOM model. We do not change anything about how propagation and condensation are performed, and the associated requirements. closes #486
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves [#486]
docs/have been added/updated if necessarymake testhas been run locally[ ] tests have been added/updated (if applicable)[ ] CHANGELOG.md has been updated.Propagation and condensation of "propagatable" slots is currently only defined in the specification for the SSSOM/TSV format. This is not appropriate as those operations are completely independent of the format – propagation and condensation are performed identically regardless of whether a mapping set is read/written from/to a SSSOM/TSV file, a SSSOM/JSON file, or a RDF file.
So in this PR, we move the definition of those operations to the general introduction (serialisation-independent) of the SSSOM model.
We do not change anything about how propagation and condensation are performed, and the associated requirements.