Add support for image block in tutorial information page #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozenhelium
force-pushed
the
feature/tutorial-image-block
branch
from
bbc0e95 to
4946f6c
Compare
frozenhelium
force-pushed
the
feature/tutorial-image-block
branch
from
4946f6c to
3a4c238
Compare
tnagorra
reviewed
Aug 1, 2025
Comment on lines
93
to
109
| const result = await createTutorialAsset({ | ||
| data: { | ||
| clientId: ulid(), | ||
| file, | ||
| mimetype: selectedEnum, | ||
| tutorial: tutorialId, | ||
| }, | ||
| }); | ||
|
|
||
| if ( | ||
| // eslint-disable-next-line no-underscore-dangle | ||
| result.data?.createTutorialAsset.__typename === 'TutorialAssetTypeMutationResponseType' | ||
| && result.data.createTutorialAsset.ok | ||
| && result.data.createTutorialAsset.result | ||
| ) { | ||
| onChange(result.data.createTutorialAsset.result.id, name); | ||
| } |
tnagorra
requested changes
Aug 1, 2025
Comment on lines
76
to
83
| const geoJsonResponse = await fetch( | ||
| previewResponse.tutorialAsset.file.url, | ||
| ); | ||
|
|
||
| const rawGeoJson = await geoJsonResponse.json(); | ||
|
|
||
| // TODO: validate | ||
| setGeoJson(rawGeoJson); |
Comment on lines
+625
to
+627
| validate: { | ||
| objectGeometry: JSON.stringify(feature.geometry, null, 4), | ||
| } satisfies ValidatePropertyInputFields, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on