Skip to content

Commit b45021a

Browse files
committed
fix(completeness)!: sync source_layer to firebase for completeness project
- rename source_name to source_layer for vector layer
1 parent 235b7eb commit b45021a

File tree

5 files changed

+51
-12
lines changed

5 files changed

+51
-12
lines changed

apps/project/tests/query_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ def setUpClass(cls):
273273
"custom": {
274274
"url": "https://custom-osm-data/{x}/{y}/{z}.pbf",
275275
"credits": "custom osm",
276-
"source_name": "custom-source-name",
276+
"source_layer": "custom-source-name",
277277
"min_zoom": 0,
278278
"max_zoom": 14,
279279
},

project_types/tile_map_service/completeness/project.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@ def get_project_specifics_for_firebase(self):
146146
vector=firebase_models.FbObjVectorTileServerOverlay(
147147
tileServer=firebase_models.FbObjVectorTileServer(
148148
name=vector_tile_server_name_enum_to_firebase(tsp_overlay.vector.tile_server.name),
149+
sourceLayer=tsp_overlay.vector.tile_server.get_config()["source_layer"],
149150
credits=tsp_overlay.vector.tile_server.get_config()["credits"],
150151
url=tsp_overlay.vector.tile_server.get_config()["url"],
151152
minZoom=tsp_overlay.vector.tile_server.get_config()["min_zoom"],

schema.graphql

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1491,7 +1491,7 @@ input ProjectUpdateInput {
14911491
}
14921492

14931493
type ProjectVectorTileServerCommonConfig {
1494-
sourceName: String!
1494+
sourceLayer: String!
14951495
credits: String!
14961496
}
14971497

@@ -1513,7 +1513,7 @@ input ProjectVectorTileServerConfigInput {
15131513

15141514
type ProjectVectorTileServerCustomConfig {
15151515
url: String!
1516-
sourceName: String!
1516+
sourceLayer: String!
15171517
credits: String!
15181518
minZoom: Int!
15191519
maxZoom: Int!
@@ -2109,13 +2109,13 @@ type ValidateTutorialTaskPropertyType {
21092109
}
21102110

21112111
input VectorTileServerCommonConfigInput {
2112-
sourceName: String!
2112+
sourceLayer: String!
21132113
credits: String!
21142114
}
21152115

21162116
input VectorTileServerCustomConfigInput {
21172117
url: String!
2118-
sourceName: String!
2118+
sourceLayer: String!
21192119
credits: String!
21202120
minZoom: Int!
21212121
maxZoom: Int!

utils/geo/vector_tile_server/models.py

Lines changed: 44 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,27 @@
44

55
from utils import fields as custom_fields
66

7-
from .config import VectorConfig, VectorTileServerNameEnum, VectorTileServerNormConfig
7+
from .config import VectorConfig, VectorTileServerNameEnum
8+
9+
10+
class VectorTileServerInstanceConfig(typing.TypedDict):
11+
url: str
12+
credits: str
13+
min_zoom: int
14+
max_zoom: int
15+
source_layer: str
816

917

1018
class VectorTileServerCustomConfig(BaseModel):
1119
url: custom_fields.PydanticVectorTileServerUrl
12-
source_name: custom_fields.PydanticLongText
20+
source_layer: custom_fields.PydanticLongText
1321
credits: custom_fields.PydanticLongText
1422
min_zoom: custom_fields.PydanticZoomLevel
1523
max_zoom: custom_fields.PydanticZoomLevel
1624

1725

1826
class VectorTileServerCommonConfig(BaseModel):
19-
source_name: custom_fields.PydanticLongText
27+
source_layer: custom_fields.PydanticLongText
2028
credits: custom_fields.PydanticLongText
2129

2230

@@ -28,17 +36,47 @@ class VectorTileServerConfig(BaseModel):
2836
open_free_map: VectorTileServerCommonConfig | None = None
2937
versatiles: VectorTileServerCommonConfig | None = None
3038

31-
def get_config(self) -> VectorTileServerNormConfig:
39+
def get_config(self) -> VectorTileServerInstanceConfig:
3240
if self.name == VectorTileServerNameEnum.CUSTOM:
3341
assert self.custom is not None
3442
return {
3543
"url": self.custom.url,
3644
"credits": self.custom.credits,
3745
"min_zoom": self.custom.min_zoom,
3846
"max_zoom": self.custom.max_zoom,
39-
"layers": [self.custom.source_name],
47+
"source_layer": self.custom.source_layer,
48+
}
49+
50+
conf = VectorConfig.get_config(self.name)
51+
52+
if self.name == VectorTileServerNameEnum.OPEN_STREET_MAP:
53+
assert self.open_street_map is not None
54+
return {
55+
"source_layer": self.open_street_map.source_layer,
56+
"url": conf["url"],
57+
"credits": conf["credits"],
58+
"min_zoom": conf["min_zoom"],
59+
"max_zoom": conf["max_zoom"],
60+
}
61+
if self.name == VectorTileServerNameEnum.OPEN_FREE_MAP:
62+
assert self.open_free_map is not None
63+
return {
64+
"source_layer": self.open_free_map.source_layer,
65+
"url": conf["url"],
66+
"credits": conf["credits"],
67+
"min_zoom": conf["min_zoom"],
68+
"max_zoom": conf["max_zoom"],
69+
}
70+
if self.name == VectorTileServerNameEnum.VERSATILES:
71+
assert self.versatiles is not None
72+
return {
73+
"source_layer": self.versatiles.source_layer,
74+
"url": conf["url"],
75+
"credits": conf["credits"],
76+
"min_zoom": conf["min_zoom"],
77+
"max_zoom": conf["max_zoom"],
4078
}
41-
return VectorConfig.get_config(self.name)
79+
typing.assert_never(self.name)
4280

4381
# FIXME(tnagorra): Do we need this?
4482
@field_validator("name", mode="before")

0 commit comments

Comments
 (0)