Skip to content

Conversation

@tnagorra
Copy link
Collaborator

@tnagorra tnagorra commented Sep 1, 2025

Depends on

Changes

  • Fix issue with getting user data from firebase
  • Make logs more verbose when pulling data for user and usergroup membership
  • Fix "archived at" value when pushing usergroup data to firebase

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.30%. Comparing base (9e0d748) to head (6972d1e).
⚠️ Report is 6 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/contributor/firebase/utils.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #135      +/-   ##
===========================================
+ Coverage    80.27%   80.30%   +0.03%     
===========================================
  Files          176      176              
  Lines         8877     8892      +15     
  Branches       799      800       +1     
===========================================
+ Hits          7126     7141      +15     
  Misses        1457     1457              
  Partials       294      294              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

susilnem
susilnem previously approved these changes Sep 1, 2025
@tnagorra tnagorra merged commit 6798969 into develop Sep 1, 2025
6 checks passed
@tnagorra tnagorra deleted the fix/user-data-pull branch September 1, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants